Page MenuHomeFreeBSD

Replacing iterating over rootpath by strsep
ClosedPublic

Authored by kczekirda on May 14 2017, 5:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 7:24 PM
Unknown Object (File)
Tue, Oct 14, 7:24 PM
Unknown Object (File)
Tue, Oct 14, 7:24 PM
Unknown Object (File)
Tue, Oct 14, 7:24 PM
Unknown Object (File)
Tue, Oct 14, 8:28 AM
Unknown Object (File)
Tue, Oct 14, 3:47 AM
Unknown Object (File)
Sat, Oct 11, 7:10 PM
Unknown Object (File)
Thu, Oct 9, 2:55 PM
Subscribers

Details

Summary

Replacing iteration over chars array by strsep.

Sponsored by: Oktawave

Test Plan

Tested on:

option root-path "192.168.22.1:/tftproot";
option root-path "/tftproot";

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kczekirda edited the summary of this revision. (Show Details)

I reviewed that earlier.
If you guys accept that I will commit it.

This revision is now accepted and ready to land.May 14 2017, 5:51 PM
jhb added inline comments.
sys/boot/common/dev_net.c
397 โ†—(On Diff #28329)

Not sure if strlcpy() is defined to handle overlapping regions? In that case I think you may want to stick with memmove/bcopy here as those handle overlapping copies.

This revision now requires review to proceed.May 19 2017, 9:22 PM
jhb added inline comments.
sys/boot/common/dev_net.c
397 โ†—(On Diff #28329)

Thanks, my last suggestion / nit would be to fix the old style bug since you are changing this line anyway and put spaces around the '+'.

This revision is now accepted and ready to land.May 22 2017, 8:05 PM
This revision was automatically updated to reflect the committed changes.