Page MenuHomeFreeBSD
Differential D10726

Replacing iterating over rootpath by strsep
ClosedPublic
Actions

Authored by kczekirda on May 14 2017, 5:07 PM.
Tags
None
Referenced Files
F164611965: D10726.id28329.diff
Sun, Aug 2, 11:17 AM
Unknown Object (File)
Thu, Jul 30, 9:41 PM
Unknown Object (File)
Tue, Jul 28, 7:42 PM
Unknown Object (File)
Sat, Jul 25, 4:53 PM
Unknown Object (File)
Fri, Jul 24, 11:01 PM
Unknown Object (File)
Fri, Jul 24, 10:42 AM
Unknown Object (File)
Thu, Jul 23, 1:43 AM
Unknown Object (File)
Mon, Jul 20, 1:54 AM
View All Files
Subscribers
emaste
jhb

Details

Reviewers
tsoome
bapt
oshogbo
jhb
Commits
rS318678: Replacing iterating over rootpath by strsep(3).
Summary

Replacing iteration over chars array by strsep.

Sponsored by: Oktawave

Test Plan

Tested on:

option root-path "192.168.22.1:/tftproot";
option root-path "/tftproot";

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kczekirda created this revision.May 14 2017, 5:07 PM
kczekirda edited the summary of this revision. (Show Details)
oshogbo accepted this revision.May 14 2017, 5:51 PM

I reviewed that earlier.
If you guys accept that I will commit it.

This revision is now accepted and ready to land.May 14 2017, 5:51 PM
emaste added a subscriber: emaste.May 17 2017, 6:16 PM
tsoome accepted this revision.May 17 2017, 6:19 PM

LGTM.

jhb added a subscriber: jhb.May 17 2017, 6:34 PM
jhb added inline comments.
sys/boot/common/dev_net.c
397 ↗(On Diff #28329)

Not sure if strlcpy() is defined to handle overlapping regions? In that case I think you may want to stick with memmove/bcopy here as those handle overlapping copies.

bapt accepted this revision.May 17 2017, 6:55 PM
kczekirda updated this revision to Diff 28585.May 19 2017, 9:22 PM
kczekirda edited edge metadata.
This revision now requires review to proceed.May 19 2017, 9:22 PM
kczekirda marked an inline comment as done.May 19 2017, 9:23 PM
jhb accepted this revision.May 22 2017, 8:05 PM
jhb added inline comments.
sys/boot/common/dev_net.c
397 ↗(On Diff #28329)

Thanks, my last suggestion / nit would be to fix the old style bug since you are changing this line anyway and put spaces around the '+'.

This revision is now accepted and ready to land.May 22 2017, 8:05 PM
Closed by commit rS318678: Replacing iterating over rootpath by strsep(3). (authored by oshogbo). · Explain WhyMay 22 2017, 8:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
boot/
common/
14 lines

Diff 28692

View Options

head/sys/boot/common/dev_net.c

Loading...