Add asserts to verify stability of struct proc and struct thread layouts.
ClosedPublic
Actions

Authored by kib on Apr 27 2017, 3:09 PM.

Details

Reviewers

jhb
emaste
vangyzen
badger

Commits

rS317523: Add asserts to verify stability of struct proc and struct thread layouts.

Test Plan

I built i386 UP debugging kernel, and amd64 SMP debugging/production kernels with this patch. Make universe is due after acceptance.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Apr 27 2017, 3:09 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 27 2017, 3:09 PM

Harbormaster failed remote builds in B8939: Diff 27791!Apr 27 2017, 3:14 PM

One moment is probably worth a clarification. I believe that locks have stable layout now, regardless of the witness, lock profiling or other supportive machinery. If this becomes no longer the case, then asserts would be only enabled for production kernels on all branches.

vangyzen accepted this revision.Apr 27 2017, 4:28 PM

This revision is now accepted and ready to land.Apr 27 2017, 4:28 PM

Yes, it seems LOCK_PROFILING no longer changes 'struct lock_object'.

badger accepted this revision.Apr 27 2017, 4:56 PM

emaste accepted this revision.Apr 27 2017, 5:35 PM

Closed by commit rS317523: Add asserts to verify stability of struct proc and struct thread layouts. (authored by kib). · Explain WhyApr 27 2017, 9:25 PM

This revision was automatically updated to reflect the committed changes.