Page MenuHomeFreeBSD

Alternate solution to D10462
ClosedPublic

Authored by dim on Apr 24 2017, 7:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 7, 7:44 AM
Unknown Object (File)
Wed, May 6, 3:10 AM
Unknown Object (File)
Fri, May 1, 4:06 PM
Unknown Object (File)
Thu, Apr 30, 7:02 PM
Unknown Object (File)
Tue, Apr 28, 12:05 AM
Unknown Object (File)
Apr 7 2026, 4:25 PM
Unknown Object (File)
Mar 22 2026, 5:15 AM
Unknown Object (File)
Mar 20 2026, 3:29 AM
Subscribers

Details

Summary

In D10462, I swapped the test around to get rid of gcc 4.2's warning
about usr.bin/diff/diffreg.c. However, @brooks noted similarly to
what I said there, that re-using i is pretty confusing.

So here's another approach: store the return value from fetch() in a
dedicated variable f, and initialize it to zero before the if.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable