Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| tools/build/options/makeman | ||
|---|---|---|
| 12 ↗ | (On Diff #27422) | s/it // |
| tools/build/options/makeman | ||
|---|---|---|
| 4 ↗ | (On Diff #27422) | Seemed like unnecessary whitespace with the longer comments below, and to group it into a header/copyright block. |
| 9 ↗ | (On Diff #27422) | I think "knob of the same name" is perfectly cromulent by itself, but "of the ... of the" does seem awkward. Will change. |
This is helpful, though I think it would also be useful if the comments at the top of src.conf.5 pointed back to makeman somehow (as otherwise if you are looking at src.conf.5 you wouldn't know to even look in tools/build/options). I still think having a 'make' shortcut in share/man/man5/Makefile ala 'make sysent' in sys/kern/Makefile would be most helpful. 'make src.conf.5' would be nice if you could trick make into only running it explicitly and never implicitly (e.g. never during buildworld)
| head/tools/build/options/makeman | ||
|---|---|---|
| 11 | This is incorrect, since it does not invoke 'make showconfig' (options * architectures) times, it is invoked once per architecture. Maybe invokes 'make showconfig' to determine, for each option on each supported architecture, whether the default setting is always? Or, "For each option on each supported architecture this script determines whether" (omitting mention of "make showconfig"). I think there's some value in referencing the use of make showconfig (to understand what information the script is actually using), but maybe folks can just look at the script to see how it works if they care. | |
| head/tools/build/options/makeman | ||
|---|---|---|
| 11 | Agreed about the value of showing specifically what it does, since this script is... dense. Oh, and I wrote "invoices". Sorry about that. For each supported architecture, 'make showconfig' is invoked for each option to | |