Page MenuHomeFreeBSD
Differential D10386

Do not double free the memory in if_clone.
ClosedPublic
Actions

Authored by kan on Apr 13 2017, 4:32 PM.
Tags
None
Referenced Files
F156669923: D10386.id36939.diff
Fri, May 15, 1:51 PM
F156651167: D10386.id27414.diff
Fri, May 15, 10:07 AM
Unknown Object (File)
Thu, May 14, 8:01 PM
Unknown Object (File)
Tue, May 12, 10:40 AM
Unknown Object (File)
Sat, May 9, 4:27 PM
Unknown Object (File)
Sat, May 9, 8:23 AM
Unknown Object (File)
Sat, May 9, 8:13 AM
Unknown Object (File)
Wed, May 6, 10:13 AM
View All Files
Subscribers
ae
imp

Details

Reviewers
glebius
ae
Commits
rS327109: Remove some trailing whitespace.
rS327108: Do not double free the memory in if_clone.
Summary

if_clone_attach function will drop the reference on failure which will
free the if_clone structure. No need to do it second time.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kan created this revision.Apr 13 2017, 4:32 PM
Herald added a subscriber: ae. · View Herald TranscriptApr 13 2017, 4:32 PM
ae accepted this revision.Apr 13 2017, 5:19 PM

I'm not glebius@, but the patch looks correct.

This revision is now accepted and ready to land.Apr 13 2017, 5:19 PM
glebius accepted this revision.Apr 25 2017, 4:23 PM

Thanks! Please commit whitespace separately from functional changes.

Closed by commit rS327108: Do not double free the memory in if_clone. (authored by kan). · Explain WhyDec 23 2017, 4:24 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptDec 23 2017, 4:24 PM

Revision Contents
Changeset List

PathSize
head/
sys/
net/
8 lines

Diff 36939

View Options

head/sys/net/if_clone.c

Loading...