Remove unnecessary check for NULL mbuf in soreceive_generic()
ClosedPublic
Actions

Authored by pkelsey on Apr 8 2017, 6:00 PM.

Tags

None

Referenced Files

	F167948513: D10322.id.diff
	Tue, Aug 25, 2:09 PM

	Unknown Object (File)
	Thu, Aug 20, 6:11 PM

	Unknown Object (File)
	Thu, Aug 13, 9:06 PM

	Unknown Object (File)
	Thu, Aug 13, 9:06 PM

	Unknown Object (File)
	Thu, Aug 13, 9:05 PM

	Unknown Object (File)
	Thu, Aug 13, 8:44 PM

	Unknown Object (File)
	Thu, Aug 13, 7:43 PM

	Unknown Object (File)
	Wed, Aug 12, 2:24 PM

View All Files

Subscribers

emaste

imp

Details

Reviewers

glebius
gnn
bms
emaste

Commits

rS317421: Remove unnecessary check for NULL mbuf in soreceive_generic().

Summary

m is never NULL here.

This check has been redundant since it was introduced in r162554.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pkelsey created this revision.Apr 8 2017, 6:00 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 8 2017, 6:00 PM

pkelsey added a reviewer: bms.Apr 8 2017, 6:02 PM

Harbormaster completed remote builds in B8613: Diff 27236.Apr 8 2017, 6:37 PM

emaste added a subscriber: emaste.Apr 18 2017, 1:38 PM

glebius accepted this revision.Apr 25 2017, 4:25 PM

This revision is now accepted and ready to land.Apr 25 2017, 4:25 PM

I applied this change to my WIP tree a while back without trouble.

Closed by commit rS317421: Remove unnecessary check for NULL mbuf in soreceive_generic(). (authored by pkelsey). · Explain WhyApr 25 2017, 7:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

uipc_socket.c

2 lines

Diff 27727

View Options

head/sys/kern/uipc_socket.c

Remove unnecessary check for NULL mbuf in soreceive_generic()ClosedPublicActions