Page MenuHomeFreeBSD

devel/kf5-extra-cmake-modules: Make qt5-help a build-dependency
ClosedPublic

Authored by rakuco on Apr 2 2017, 10:37 AM.

Details

Summary

Make the dependency on devel/qt5-help a build-time dependency, not a build+run one.

It is only used to produce the .qch file, so it does not need to be present at runtime. This turns kf5-e-c-m into a port that has no dependency on Qt5 (or basically any other port), which makes it easier to depend on it.

Test Plan

Built other kf5 ports successfully.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Looks good to me. But I faintly remember one of the other options being broken -- you might want to fix that too while your on it :D

This revision is now accepted and ready to land.Apr 2 2017, 7:43 PM

But I faintly remember one of the other options being broken -- you might want to fix that too while your on it :D

Don't you mean TEST? There's a comment there saying TEST=OFF is broken.

This revision was automatically updated to reflect the committed changes.