Page MenuHomeFreeBSD

implement initial Hyperv keyboard synthetic driver
ClosedPublic

Authored by honzhan_microsoft.com on Mar 30 2017, 5:59 AM.

Details

Summary

This patch implements synthetic keyboard driver for FreeBSD on Hyper-V Gen2. In Gen2 mode, the legacy keyboard does not work.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Looks pretty good to me. Some minor code style suggestion.

sys/dev/hyperv/input/hv_kbdc.c
67–69 ↗(On Diff #26807)

Better use C style comment, or '#if 0 ... #endif'

107–118 ↗(On Diff #26810)

May be we should use more consistent style of comment?

/*
 *
 */

or your preference:

/**
 *
 */
307 ↗(On Diff #26810)

I'd prefer for (;;)

331–342 ↗(On Diff #26810)

We don't indent switch-case:

switch () {
case XXX:
    aaaa;
case YYY:
    bbbb;
default:
    cccc;
}
This revision is now accepted and ready to land.Mar 30 2017, 7:54 AM
honzhan_microsoft.com edited edge metadata.
This revision now requires review to proceed.Mar 30 2017, 8:08 AM
This revision was automatically updated to reflect the committed changes.