Currently, less(1) uses K&R prototypes, which both fails to provide useful
compiler-time type checking, and also causes problems for targets where
multiple incompatible calling conventions may be selected based on argument
types. This change switches less(1) to ANSI prototypes.
Details
Details
Tested at SRI and Cambridge in CheriBSD.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
LGTM with a few nitpicks noted inline
contrib/less/charset.c | ||
---|---|---|
560 ↗ | (On Diff #26698) | Ick, hopefully we can convince upstream to drop the #define constant const and just use const. |
contrib/less/cmdbuf.c | ||
1389 ↗ | (On Diff #26698) | Hmm, this file has an "interesting" style. |
1390 ↗ | (On Diff #26698) | is this > 80 cols? |
contrib/less/ifile.c | ||
52 ↗ | (On Diff #26698) | drop register? |
contrib/less/main.c | ||
335 ↗ | (On Diff #26698) | drop register? |
contrib/less/output.c | ||
444 ↗ | (On Diff #26698) | register |
contrib/less/pattern.c | ||
273 ↗ | (On Diff #26698) | line length? |
contrib/less/regexp.c | ||
1052 ↗ | (On Diff #26698) | register |
Comment Actions
Line wrap two overlong lines (with new type information) to 80 characters.
Remove all instances of "register". (There were a lot of these!)
Comment Actions
Catch a couple of further instances of K&R prototypes not caught by current
compiler warnings.