Page MenuHomeFreeBSD

Fix memory leak in autofs
AcceptedPublic

Authored by trix_juniper.net on Mar 20 2017, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 3 2024, 1:45 AM
Unknown Object (File)
Aug 31 2024, 3:24 PM
Unknown Object (File)
Aug 24 2024, 3:26 AM
Unknown Object (File)
Aug 23 2024, 6:03 AM
Unknown Object (File)
Aug 23 2024, 6:02 AM
Unknown Object (File)
Aug 23 2024, 5:32 AM
Unknown Object (File)
Aug 18 2024, 8:18 AM
Unknown Object (File)
Aug 16 2024, 2:53 AM
Subscribers

Details

Reviewers
trasz
ngie
Summary

common.c create_directory
Free tofree when returning early.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and later to show resolution.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

usr.sbin/autofs/common.c
155

An equivalent way to do this would be to call break instead of return here. I think this is the best way to fix the problem because it means that the cleanup path is equivalent.. but I would get signoff from trasz since he's the autofs developer/maintainer.

This revision is now accepted and ready to land.May 5 2017, 5:23 AM

I'd prefer the "break" as well.

@trix_juniper.net: this patch never made it in to base. Could you please change the return to a break and submit an updated version of the patch, so we can commit it for you?