Page MenuHomeFreeBSD

Fix memory leak in autofs
AcceptedPublic

Authored by trix_juniper.net on Mar 20 2017, 3:54 PM.

Details

Reviewers
trasz
ngie
Summary

common.c create_directory
Free tofree when returning early.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and later to show resolution.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

ngie added inline comments.Mar 20 2017, 4:25 PM
usr.sbin/autofs/common.c
155

An equivalent way to do this would be to call break instead of return here. I think this is the best way to fix the problem because it means that the cleanup path is equivalent.. but I would get signoff from trasz since he's the autofs developer/maintainer.

ngie accepted this revision.May 5 2017, 5:23 AM
This revision is now accepted and ready to land.May 5 2017, 5:23 AM
trasz edited edge metadata.May 5 2017, 2:37 PM

I'd prefer the "break" as well.

ngie added a comment.Jan 10 2019, 1:09 AM

@trix_juniper.net: this patch never made it in to base. Could you please change the return to a break and submit an updated version of the patch, so we can commit it for you?