common.c create_directory
Free tofree when returning early.
Details
Details
- Reviewers
trasz ngie - Commits
- rGbc598959090d: autofs: Plug memory leak
Use clang's static analyzer, scan-build, to find the problem and later to show resolution.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
usr.sbin/autofs/common.c | ||
---|---|---|
155 | An equivalent way to do this would be to call break instead of return here. I think this is the best way to fix the problem because it means that the cleanup path is equivalent.. but I would get signoff from trasz since he's the autofs developer/maintainer. |
Comment Actions
@trix_juniper.net: this patch never made it in to base. Could you please change the return to a break and submit an updated version of the patch, so we can commit it for you?