Fix memory leak in autofs
ClosedPublic
Actions

Authored by trix_juniper.net on Mar 20 2017, 3:54 PM.

Details

Reviewers

trasz
ngie

Commits

rGbc598959090d: autofs: Plug memory leak

Summary

common.c create_directory
Free tofree when returning early.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and later to show resolution.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trix_juniper.net created this revision.Mar 20 2017, 3:54 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 20 2017, 3:54 PM

ngie added inline comments.Mar 20 2017, 4:25 PM

usr.sbin/autofs/common.c
155	An equivalent way to do this would be to call break instead of return here. I think this is the best way to fix the problem because it means that the cleanup path is equivalent.. but I would get signoff from trasz since he's the autofs developer/maintainer.

ngie accepted this revision.May 5 2017, 5:23 AM

This revision is now accepted and ready to land.May 5 2017, 5:23 AM

I'd prefer the "break" as well.

@trix_juniper.net: this patch never made it in to base. Could you please change the return to a break and submit an updated version of the patch, so we can commit it for you?

Closed by commit rGbc598959090d: autofs: Plug memory leak (authored by ngie, committed by imp). · Explain WhyAug 10 2025, 1:56 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGbc598959090d: autofs: Plug memory leak.