Page MenuHomeFreeBSD

Fix memory leak in autofs
ClosedPublic

Authored by trix_juniper.net on Mar 20 2017, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 3:56 PM
Unknown Object (File)
Fri, Oct 10, 9:52 AM
Unknown Object (File)
Fri, Oct 10, 9:51 AM
Unknown Object (File)
Fri, Oct 10, 3:27 AM
Unknown Object (File)
Sep 15 2025, 5:16 AM
Unknown Object (File)
Sep 14 2025, 12:35 AM
Unknown Object (File)
Sep 14 2025, 12:32 AM
Unknown Object (File)
Sep 12 2025, 4:27 AM
Subscribers

Details

Summary

common.c create_directory
Free tofree when returning early.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and later to show resolution.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

usr.sbin/autofs/common.c
155

An equivalent way to do this would be to call break instead of return here. I think this is the best way to fix the problem because it means that the cleanup path is equivalent.. but I would get signoff from trasz since he's the autofs developer/maintainer.

This revision is now accepted and ready to land.May 5 2017, 5:23 AM

I'd prefer the "break" as well.

@trix_juniper.net: this patch never made it in to base. Could you please change the return to a break and submit an updated version of the patch, so we can commit it for you?

This revision was automatically updated to reflect the committed changes.