Page MenuHomeFreeBSD
Differential D10047

fill x86 padding with INT3 instead of NOP
ClosedPublic
Actions

Authored by emaste on Mar 18 2017, 6:25 PM.
Tags
None
Referenced Files
F103817981: D10047.diff
Fri, Nov 29, 8:27 PM
Unknown Object (File)
Oct 28 2024, 8:56 PM
Unknown Object (File)
Oct 28 2024, 6:16 PM
Unknown Object (File)
Oct 9 2024, 2:12 AM
Unknown Object (File)
Sep 22 2024, 3:52 AM
Unknown Object (File)
Sep 12 2024, 7:28 AM
Unknown Object (File)
Sep 11 2024, 4:58 PM
Unknown Object (File)
Sep 8 2024, 1:55 PM
View All 63 Files
Subscribers
None

Details

Reviewers
jhb
kib
dim
Commits
rS315522: use INT3 instead of NOP for x86 binary padding
Summary

We should never end up executing the inter-function padding, so we're better off faulting than silently carrying on to whatever function happens to be next.

LLD will do this by default (although it currently pads with zeros).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Mar 18 2017, 6:25 PM
dim accepted this revision.Mar 18 2017, 8:17 PM

Yes, that seems like a good idea to me.

This revision is now accepted and ready to land.Mar 18 2017, 8:17 PM
kib accepted this revision.Mar 18 2017, 10:42 PM
Closed by commit rS315522: use INT3 instead of NOP for x86 binary padding (authored by emaste). · Explain WhyMar 19 2017, 12:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
contrib/
binutils/
ld/
emulparams/
2 lines
2 lines
sys/
conf/
6 lines
6 lines

Diff 26398

View Options

head/contrib/binutils/ld/emulparams/elf_i386.sh

Loading...
View Options

head/contrib/binutils/ld/emulparams/elf_x86_64.sh

Loading...
View Options

head/sys/conf/ldscript.amd64

Loading...
View Options

head/sys/conf/ldscript.i386

Loading...