Thanks for the patch.
Please commit it.

@jhb yes, of course.

In D45293#1033438, @bz wrote:

In D45293#1033418, @bz wrote:

There may be another code path which can still trigger this (or another) problem leading to a FW crash with the old 8xxx/9xxx cards (leading to follow-up KASSERT triggers on GENERIC).

I'll have a look tomorrow; in case you see anything but

iwlwifi0: lkpi_sta_scan_to_auth:1310: mo_sta_state(NONE) failed: -5
iwlwifi0: lkpi_iv_newstate: error -1 during state transition 5 (RUN) -> 2 (AUTH)

after a firmware crash, please follow up here or on the PR and let me know.

Doh! https://reviews.freebsd.org/D43967 never made it; the description needs updating etc. but the change should go into main as well; it's likely I hit that race. Grrr decade old net80211 problems everyone ignored.

Add a comment explaining why we check mediasize this late.

In D45293#1033443, @imp wrote:

Taerdown -> teardown in commit message.

Taerdown -> teardown in commit message.

Updated Test Results with Fix

• The test results in https://reviews.freebsd.org/D45215#1032189 still had some port build errors, so they all have been fixed locally.
• The fix has been rebased to 14.1-BETA3. (2a964a7fc3)
• The tendency of the results are the same as https://reviews.freebsd.org/D45215#1032189.

In D45293#1033418, @bz wrote:

There may be another code path which can still trigger this (or another) problem leading to a FW crash with the old 8xxx/9xxx cards (leading to follow-up KASSERT triggers on GENERIC).

I'll have a look tomorrow; in case you see anything but

iwlwifi0: lkpi_sta_scan_to_auth:1310: mo_sta_state(NONE) failed: -5
iwlwifi0: lkpi_iv_newstate: error -1 during state transition 5 (RUN) -> 2 (AUTH)

after a firmware crash, please follow up here or on the PR and let me know.

I'll try to deal with the "pr_debug" marked instances the next days.

In D45293#1033422, @imp wrote:

"Tear"

"Tear"

Updated wrong review. Bring back the proper patch.

There may be another code path which can still trigger this (or another) problem leading to a FW crash with the old 8xxx/9xxx cards (leading to follow-up KASSERT triggers on GENERIC).

Compilation fix.

Compilation fix.

So silly question: what are we trying to solve with these packages in first place?
Historic value to have a copy of the packages saved before they disappear?
Give users a graphical desktop (unlikely with this list)?
Because we always did?
...?

I don't understand enough to review in depth but looks OK. One nit I noticed in a comment.

OK, this is good enough for now.

correct history

In D45243#1033059, @des wrote:

In D45243#1032859, @pjd wrote:

In D45243#1032364, @des wrote:

Have you considered implementing Apple's copyfile API?

I did, but I cannot commit that much time to implement it.

I'm not suggesting implementing the full API; just COPYFILE_DATA and COPYFILE_STAT and a handful of modifiers (COPYFILE_DATA_SPARSE, COPYFILE_EXCL, COPYFILE_MOVE, COPYFILE_NOFOLLOW, COPYFILE_UNLINK) should suffice. I'd offer to help, but I've seen the source code (it's on GitHub under APSL) so I probably shouldn't.

Update commit message as suggested by jrtc27

Oh and MFC after?

Though please change your Fixes to be 3bfbb521fef5 ("ls: Improve POSIX compatibility for -g and -n.")

Can you please add IOMMU to arm64 NOTES?

Mention EXAMPLES section in mixer_get_nmixers().

Update mixer_get_nmixers() entry in mixer.3.

Anyone any comments? Otherwise I'll put that in soon.

Anyone? As otherwise this will go in within 24h.

Anyone? Otherwise this will go in within 24h.

The updates look good to me.

LGTM. "whether an attempt to access the file" is definitely an improvement

So for mostly idle machines, this increases the spacing between ':', ',', and values. Perhaps doing it conditionally is worse because the placement of the values would blink.

be more explicit

In D44945#1033260, @bz wrote:

@jrm given I am not a ports committer how do I proceed? I assume I need an Approved by: line from someone?