HomeFreeBSD

copystr(9): Move to deprecate [2/2]
Audit RequiredrS360944

Description

copystr(9): Move to deprecate [2/2]

Unlike the other copy*() functions, it does not serve to copy from one
address space to another or protect against potential faults. It's just
an older incarnation of the now-more-common strlcpy().

Add a coccinelle script to tools/ which can be used to mechanically
convert existing instances where replacement with strlcpy is trivial.
In the two cases which matched, fuse_vfsops.c and union_vfsops.c, the
code was further refactored manually to simplify.

Replace the declaration of copystr() in systm.h with a small macro
wrapper around strlcpy.

Remove N redundant MI implementations of copystr. For MIPS, this
entailed inlining the assembler copystr into the only consumer,
copyinstr, and making the latter a leaf function.

Reviewed by: jhb
Differential Revision: https://reviews.freebsd.org/D24672

Details

Group Auditors
Restricted Owners Package
Provenance
cemAuthored on
Reviewer
jhb
Differential Revision
D24672: copystr(9): Move to deprecate
Parents
rS360943: copystr(9): Move to deprecate [1/2]
Branches
Unknown
Tags
Unknown