HomeFreeBSD

LRO: Don't merge ACK and non-ACK packets together

Description

LRO: Don't merge ACK and non-ACK packets together

LRO was willing to merge ACK and non-ACK packets together. This
can cause incorrect th_ack values to be reported up the stack.
While non-ACKs are quite unlikely to appear in practice, LRO's
behaviour is against the spec. Make LRO unwilling to merge
packets with different TH_ACK flag values in order to fix the
issue.

Found by: Sysunit test
Differential Revision: https://reviews.freebsd.org/D33775
Reviewed by: rrs

(cherry picked from commit 3284f4925f697ad7cc2aa4761ff5cf6ce98fd623)

Details

Provenance
rstoneAuthored on Feb 8 2022, 3:08 PM
hselaskyCommitted on Feb 8 2022, 3:08 PM
Reviewer
rrs
Differential Revision
D33775: LRO: Don't merge ACK and non-ACK packets together
Parents
rG22b24dc1abb3: LRO: Fix lost packets when merging 1 payload with an ACK
Branches
Unknown
Tags
Unknown