HomeFreeBSD

hkbd: remove error detection in KDSKBSTATE ioctl

Description

hkbd: remove error detection in KDSKBSTATE ioctl

The KDSKBSTATE ioctl brings the LED up. However, some keyboards (like qemu
keyboard) may not have LED or failed to set the LED due to unexpected reason.
Therefore, removing the error check as ukbd(4) does allow the keyboard works
correctly with kbdcontrol(4).

Also move hw.hid.hkbd.no_leds sysctl out of HID_BUG thus users can
disable setting LEDs

PR: 288968
Reviewed by: wulf
Tested by: trashcan@ellael.org, marklmi26-fbsd@yahoo.com, trkellers@gmail.coom
Approved by: lwsu (mentor), markj (mentor)
MFC after 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52101

(cherry picked from commit 1685192ea1faac28f2d4feede53e70b6a380500f)
(cherry picked from commit 6ea7e1f92882706cc8818a13e8bd55b7d2f48e27)

Details

Provenance
aokblastAuthored on Aug 21 2025, 5:59 PM
emasteCommitted on Thu, Oct 2, 4:41 PM
Reviewer
wulf
Differential Revision
D52101: hkbd: remove erorr detection in KDSKBSTATE ioctl
Parents
rG77e2ddc52c59: nss_tacplus: Fix typo in Makefile
Branches
Unknown
Tags
Unknown