Fri, Nov 16
Sep 18 2017
Fine by me. +1 to what @mat said.
Note that Mk/Uses/xfce.mk is maintained by xfce@FreeBSD.org, not portmgr.
Sep 16 2017
Testing with non default options showed that disabling the GTK2 option causes failures in other XFCE ports, so I made it a non option.
Works fine for me.
Sep 15 2017
Oct 23 2016
Please also include test results in the test plan section, not just a description/list of what will/has been run
@woodsb02 Please use the SUMMARY field as the proposed commit log (i've updated it this time to provide example).
ehaupt: What do you think about marking deskutils/xfce4-notification-daemon as deprecated and then removing it from ports 1 month later? My understanding is that it is no longer maintained and is fully replaced by deskutils/xfce4-notifyd?
Oct 22 2016
Why to accept this changes, without informed the maintainer (ehaupt)?
Aug 30 2016
UNOFFICIAL term is not good word (imho), because it contains unmaintained applications, so we must inform users these ports (in a future) can be removed.
You may fire when ready.
Jul 30 2016
olivierd - what are your thoughts on deprecating deskutils/xfce4-notification-daemon?
Jul 12 2016
Update diff inline with comments from olivierd
Hi olivierd, thanks for you review. I have updated my patch and responded to your comments below.
Jul 6 2016
Jun 28 2016
I'll give this a build test on -current tonight.
Thanks for the heads up.
As per comments from mat, remove hyphens from all OPTIONS_GROUP names, and also all OPTIONS names just to be safe.
Jun 27 2016
As per comment from mat, replace the dependency on a file by a dependency on the package.
It is documented in bsd.port.mk:
For all the depends, maybe you should replace the dependency on a file by a dependency on the package, say, replace:
Jun 17 2016
You'll need to bump PORTREVISION so that people get the corrected version.
As per comment from adamw:
- Do not hard code /usr/local/bin in a patch; replace with %%LOCALBASE%%/bin