Page MenuHomeFreeBSD

shichun_ma_dell.com (shichun_ma)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 16 2018, 6:25 AM (280 w, 2 d)

Recent Activity

Fri, Feb 2

shichun_ma_dell.com added inline comments to D43211: lkpi_i2c_del_adapter can't delete child when i2c_adapter remove.
Fri, Feb 2, 6:39 AM

Thu, Feb 1

shichun_ma_dell.com added a comment to D43211: lkpi_i2c_del_adapter can't delete child when i2c_adapter remove.

Any one can have a review with this diff?

Thu, Feb 1, 2:11 AM

Dec 27 2023

shichun_ma_dell.com requested review of D43211: lkpi_i2c_del_adapter can't delete child when i2c_adapter remove.
Dec 27 2023, 11:27 AM

Feb 22 2021

shichun_ma_dell.com requested review of D28848: The socket SO_LINGER option don't work..
Feb 22 2021, 6:14 AM

Feb 18 2021

shichun_ma_dell.com added a comment to D28562: fix sys_write error, only need SIGPIPE for EPIPE and socket .

I make a driver that compatable with Linux. From the application, it will not see it running on FreeBSD or Linux.
On linux, it will encounter same error without this signal sending. If I change error code, it will behave differently from linux.
I think others will also encounter similar issue , why not make a genric change that benifit all?

Feb 18 2021, 7:47 AM

Feb 13 2021

shichun_ma_dell.com added a comment to D28032: Set default alternate setting when USB audio devices are not in use, to activate power save features..

@hselasky , expecting to see your patch, and I stand by to do any test.

Feb 13 2021, 8:28 AM
shichun_ma_dell.com added a comment to D28562: fix sys_write error, only need SIGPIPE for EPIPE and socket .

@kib, sorry just realize that nfslock_write is a function in FreeBSD 12.0.
I don't have exact backtrace for it, this is an issue I debugs days before. Here is what I did. I implemented /dev/hidraw.
When run same app on Linux system, it has below strace. While there is signal SIGPIPE after write error.
Then I checked the code, and got that tdsignal(td, SIGPIPE) will be called from dofilewrite.
Here is the piece info from the whole trace file.

Feb 13 2021, 2:01 AM

Feb 10 2021

shichun_ma_dell.com added a comment to D28562: fix sys_write error, only need SIGPIPE for EPIPE and socket .

@jhb, Here is one example:

  1. in function nfslock_write, it call nfslockdans, and it's possible that nfslockdans encounter EPIPE error.
  2. application's expectation is jut got write error with return error EPIPE, while freeBSD kernel send extra signal SIGPIPE, this will cause application killed by unexpected signal.

The goal of this change is to avoid unnecessary "signal SIGPIPE" sending in kernel.

Feb 10 2021, 11:12 PM
shichun_ma_dell.com updated subscribers of D28562: fix sys_write error, only need SIGPIPE for EPIPE and socket .

@jhb , could you review this?

Feb 10 2021, 12:20 AM
shichun_ma_dell.com added a comment to D28032: Set default alternate setting when USB audio devices are not in use, to activate power save features..

@hselasky , the set chan prepare operation need wait configure message callback API finished.
I don't have good method to do that, while usually xfer starts after set alt interface.
It's ok to submit this to mainstream, this change may impact others and can be improved.

Feb 10 2021, 12:17 AM
shichun_ma_dell.com requested review of D28562: fix sys_write error, only need SIGPIPE for EPIPE and socket .
Feb 10 2021, 12:10 AM

Jan 8 2021

shichun_ma_dell.com requested review of D28032: Set default alternate setting when USB audio devices are not in use, to activate power save features..
Jan 8 2021, 3:19 AM

Nov 12 2020

shichun_ma_dell.com added a comment to D27174: Allow user to configure endpoints twice.

It's a good fix.

Nov 12 2020, 7:16 AM