Just looked at NetBSD src.
I guess we should follow what is inside https://github.com/NetBSD/src/blob/trunk/sys/arch/arm/rockchip/rk_usb.c#L338

Updated accordingly.

Probably I'm missing something when tried with git arc.
Committed https://cgit.freebsd.org/src/commit/?id=ec556724d7ad1ee117fe595728e73dc9ddf78048

Updated.

Updated accordingly.

Updated the patch. I hope I understood the comment, correct me if I'm wrong here.

In D36149#821860, @manu wrote:

In D36149#821858, @ganbold wrote:

Hopefully fixed accordingly.

Before we use to always power off the PMIC , maybe we should still do the same.

Committed: https://cgit.freebsd.org/src/commit/?id=530d5f83386092fe1e5cb220d3ca070cb9db0bfa

Committed: https://cgit.freebsd.org/src/commit/?id=530d5f83386092fe1e5cb220d3ca070cb9db0bfa

Hopefully fixed accordingly.

Updated the patch accordingly.

Ok, I hope the updated patch would work.

Ok, as @sos said, I updated the patch accordingly

In D36138#820614, @sos wrote:

In D36138#820415, @ganbold wrote:

Ah, right, updated the diff.

But you still missed a few of those bit -1's :)

Ah, right, updated the diff.

Updated the diff.

It seems linux does the same.

Could you apply some style changes?

@manu do you have rk3328 board to test?

Can you incorporate following style changes?

Maybe we should remove dev/mmc/host/dwmmc_acpi.c from files.arm64 for now?
We can add later.

Cool. Can you incorporate following style changes?
It is based on your previous clk related patches, I hope it is mostly the same.