Page MenuHomeFreeBSD
Differential D36378

Improve and make it more general RockChip USB2PHY driver.Add support for RockChip RK356X SoC.
AbandonedPublic
Actions

Authored by ganbold on Aug 28 2022, 4:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 8:21 AM
Unknown Object (File)
Nov 22 2023, 10:17 PM
Unknown Object (File)
Nov 8 2023, 9:48 AM
Unknown Object (File)
Oct 7 2023, 8:44 AM
Unknown Object (File)
Sep 20 2023, 10:15 AM
Unknown Object (File)
May 4 2023, 4:15 PM
Unknown Object (File)
Mar 5 2023, 5:56 PM
Unknown Object (File)
Feb 27 2023, 9:37 PM
View All 12 Files
Subscribers
andrew
emaste
imp
sos

Details

Reviewers
manu

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ganbold created this revision.Aug 28 2022, 4:13 AM
Herald added a reviewer: manu. · View Herald TranscriptAug 28 2022, 4:13 AM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
ganbold requested review of this revision.Aug 28 2022, 4:13 AM
Harbormaster completed remote builds in B47157: Diff 109919.Aug 28 2022, 4:13 AM
ganbold added a subscriber: sos.Aug 28 2022, 4:15 AM
manu added inline comments.Aug 30 2022, 5:25 PM
sys/arm64/rockchip/rk_usb2phy.c
136

What are those magic numbers ? Can we have some defines for them ?

ganbold updated this revision to Diff 110033.Sep 1 2022, 2:46 AM
ganbold retitled this revision from Improve and make it more general RockChip USB2PHY driver. Add support for RockChip RK356X SoC. to Improve and make it more general RockChip USB2PHY driver.Add support for RockChip RK356X SoC..

Updated accordingly.

manu added inline comments.Sep 1 2022, 7:03 AM
sys/arm64/rockchip/rk_usb2phy.c
163

This doesn't look correct.
For RK3399 bit 0 is for USB3 while bit 1 is for usb2.
For RK356x I'm not sure what you want to do.
For both I don't think that you right to the correct location.

ganbold added a comment.Sep 1 2022, 7:46 AM
This comment was removed by ganbold.
ganbold added inline comments.Sep 1 2022, 7:48 AM
sys/arm64/rockchip/rk_usb2phy.c
163

This doesn't look correct.
For RK3399 bit 0 is for USB3 while bit 1 is for usb2.
For RK356x I'm not sure what you want to do.
For both I don't think that you right to the correct location.

@sos can you comment on this?

thanks,

ganbold added a comment.Sep 1 2022, 10:31 AM

Just looked at NetBSD src.
I guess we should follow what is inside https://github.com/NetBSD/src/blob/trunk/sys/arch/arm/rockchip/rk_usb.c#L338

ganbold abandoned this revision.Dec 27 2022, 2:11 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
rockchip/
69 lines

Diff 110033

View Options

sys/arm64/rockchip/rk_usb2phy.c

Loading...