Bugzilla submission here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223815

In D12793#274492, @lifanov wrote:

I re-tested it and the port looks good now.
Would you like me to commit it?

Is there a Bugzilla issue for it?

In D12793#274236, @lifanov wrote:

OK, this works now and looks pretty good.
Can you consider making some configuration files @sample?
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#plist-config

There are two steps to it:

1. install the file with .sample suffix (like arangod.conf.sample)
2. list it with @sample in pkg-plist:

@sample %%ETCDIR%%/arangod.conf.sample

When pkg installs a package with @sample entries, these get copied to the correct location if the files are missing
and then the user can modify the configuration files without causing checksum mismatches and without the files
being clobbered on package update.

Install configuration files as samples.

Update the arangodb user directory

In D12793#274211, @lifanov wrote:

This doesn't build for me:

/work/stage/usr/local/share/arangodb/js/server/bootstrap/coordinator-database.js
CMake Error at cmake_install.cmake:87 (file):
  file INSTALL cannot find
  "/usr/home/lifanov/src/svn/freebsd/ports/head/databases/arangodb32/work/.build/var/log/arangodb3".
gmake[1]: *** [Makefile:99: install/strip] Error 1

Add the cmake patch

Update maintainer address.

Update to 3.2.8

In D12793#270047, @lifanov wrote:

In D12793#269311, @dev_dudu.ro wrote:

In D12793#268412, @lifanov wrote:

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

I'm not sure I understand what you mean - should I replace them with the actual final value - e.g. /usr/local/share, or add @dir entries for them to pkg-plist?

The directory that gets installed is /usr/local/share/arangodb3, which suggests that PORTNAME should be agangodb3?
There are several other places where arangodb3 name gets used. Example:

: ${arangod_dbpath="/var/db/arangodb3"}
: ${arangod_logpath="/var/log/arangodb3"}
: ${arangod_apppath="/var/db/arangodb3-apps"}

As for the renaming bit I was thinking of following the mongodbXY port convention and eventually add an arangodb33 port that is set to conflict with the arangodb32 port. Thoughts?

Versioning it like mongodbXY is a good idea in general, but it is useful if the two versions are incompatible or require special upgrade/migration steps (like postgresql).
Another consideration is how long do you expect people to run arangodb 3.2 once 3.3 is realeased.

Thanks!

Updated to 3.2.7
Addressed reviewer comments

In D12793#268412, @lifanov wrote:

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

Remove git dependency and add python dependency

Move USE_GITHUB to its rightful place.

Simplify the man page moving logic

Do not explicitly gzip man pages.

In D12793#265614, @lifanov wrote:

I can see in the build system that some components are hard to decouple.
Try decoupling what you can, like boost or libcurl.

In D12793#265567, @lifanov wrote:

How did you generate pkg-plist? The files listed in it are already relative to LOCALBASE and @dir should only specify directories that are empty.
The "make makeplist" target should generate a pkg-plist close to what you want, so then you need to review it and make any manual changes you need.

Silenced stage-qa and check-orphans.