Page MenuHomeFreeBSD

dev_dudu.ro
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 25 2017, 4:46 PM (331 w, 12 h)

Recent Activity

Dec 22 2017

dev_dudu.ro updated the diff for D13584: databases/mongodb36: new port.
Dec 22 2017, 5:10 PM
dev_dudu.ro updated the summary of D13584: databases/mongodb36: new port.
Dec 22 2017, 10:48 AM
dev_dudu.ro created D13584: databases/mongodb36: new port.
Dec 22 2017, 10:48 AM

Nov 28 2017

dev_dudu.ro updated the diff for D13282: Fix FreeBSD 10.x and i386 builds.
Nov 28 2017, 2:25 PM · Contributor Reviewers (ports)
dev_dudu.ro added inline comments to D13282: Fix FreeBSD 10.x and i386 builds.
Nov 28 2017, 2:18 PM · Contributor Reviewers (ports)
dev_dudu.ro updated the diff for D13282: Fix FreeBSD 10.x and i386 builds.
Nov 28 2017, 2:18 PM · Contributor Reviewers (ports)
dev_dudu.ro added inline comments to D13282: Fix FreeBSD 10.x and i386 builds.
Nov 28 2017, 2:15 PM · Contributor Reviewers (ports)
dev_dudu.ro added inline comments to D13282: Fix FreeBSD 10.x and i386 builds.
Nov 28 2017, 2:13 PM · Contributor Reviewers (ports)
dev_dudu.ro added a comment to D13282: Fix FreeBSD 10.x and i386 builds.

Bugzilla submission here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223815

Nov 28 2017, 2:09 PM · Contributor Reviewers (ports)
dev_dudu.ro created D13282: Fix FreeBSD 10.x and i386 builds.
Nov 28 2017, 2:07 PM · Contributor Reviewers (ports)

Nov 21 2017

dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

I re-tested it and the port looks good now.
Would you like me to commit it?

Is there a Bugzilla issue for it?

Nov 21 2017, 3:12 PM · Ports Committers

Nov 20 2017

dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

OK, this works now and looks pretty good.
Can you consider making some configuration files @sample?
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#plist-config

There are two steps to it:

  1. install the file with .sample suffix (like arangod.conf.sample)
  2. list it with @sample in pkg-plist:

@sample %%ETCDIR%%/arangod.conf.sample

When pkg installs a package with @sample entries, these get copied to the correct location if the files are missing
and then the user can modify the configuration files without causing checksum mismatches and without the files
being clobbered on package update.

Nov 20 2017, 11:25 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Install configuration files as samples.

Nov 20 2017, 11:25 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Update the arangodb user directory

Nov 20 2017, 3:53 PM · Ports Committers
dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

This doesn't build for me:

/work/stage/usr/local/share/arangodb/js/server/bootstrap/coordinator-database.js
CMake Error at cmake_install.cmake:87 (file):
  file INSTALL cannot find
  "/usr/home/lifanov/src/svn/freebsd/ports/head/databases/arangodb32/work/.build/var/log/arangodb3".
gmake[1]: *** [Makefile:99: install/strip] Error 1
Nov 20 2017, 3:41 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Add the cmake patch

Nov 20 2017, 3:41 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Update maintainer address.

Nov 20 2017, 10:11 AM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Update to 3.2.8

Nov 20 2017, 10:10 AM · Ports Committers

Nov 16 2017

dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

I'm not sure I understand what you mean - should I replace them with the actual final value - e.g. /usr/local/share, or add @dir entries for them to pkg-plist?

The directory that gets installed is /usr/local/share/arangodb3, which suggests that PORTNAME should be agangodb3?
There are several other places where arangodb3 name gets used. Example:

: ${arangod_dbpath="/var/db/arangodb3"}
: ${arangod_logpath="/var/log/arangodb3"}
: ${arangod_apppath="/var/db/arangodb3-apps"}

As for the renaming bit I was thinking of following the mongodbXY port convention and eventually add an arangodb33 port that is set to conflict with the arangodb32 port. Thoughts?

Versioning it like mongodbXY is a good idea in general, but it is useful if the two versions are incompatible or require special upgrade/migration steps (like postgresql).
Another consideration is how long do you expect people to run arangodb 3.2 once 3.3 is realeased.

Thanks!

Nov 16 2017, 9:44 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Updated to 3.2.7
Addressed reviewer comments

Nov 16 2017, 9:44 PM · Ports Committers

Nov 7 2017

dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

This looks pretty good, but %%DATADIR%%3 and %%DOCSDIR%%3 in pkg-plist should really be directories.
Can you consider configuring these to match the port name or maybe swithing the portname to arangodb3?

Nov 7 2017, 3:51 PM · Ports Committers

Oct 27 2017

dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Remove git dependency and add python dependency

Oct 27 2017, 5:31 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Move USE_GITHUB to its rightful place.

Oct 27 2017, 4:21 PM · Ports Committers

Oct 26 2017

dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Simplify the man page moving logic

Oct 26 2017, 3:22 PM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Do not explicitly gzip man pages.

Oct 26 2017, 2:42 PM · Ports Committers
dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

I can see in the build system that some components are hard to decouple.
Try decoupling what you can, like boost or libcurl.

Oct 26 2017, 2:41 PM · Ports Committers
dev_dudu.ro added a comment to D12793: ArangoDB FreeBSD port.

How did you generate pkg-plist? The files listed in it are already relative to LOCALBASE and @dir should only specify directories that are empty.
The "make makeplist" target should generate a pkg-plist close to what you want, so then you need to review it and make any manual changes you need.

Oct 26 2017, 10:36 AM · Ports Committers
dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.

Silenced stage-qa and check-orphans.

Oct 26 2017, 10:34 AM · Ports Committers

Oct 25 2017

dev_dudu.ro updated the diff for D12793: ArangoDB FreeBSD port.
Oct 25 2017, 11:12 PM · Ports Committers
dev_dudu.ro created D12793: ArangoDB FreeBSD port.
Oct 25 2017, 4:48 PM · Ports Committers