databases/mongodb36: new port
ClosedPublic
Actions

Authored by dev_dudu.ro on Dec 22 2017, 10:48 AM.

Details

Reviewers

lifanov
linimon

Commits

rP457783: add new port: MongoDB 3.6.0

Summary

Based on mongodb32 and mongodb34 ports with necessary changes for 3.6. Bugzilla report here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224303

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dev_dudu.ro created this revision.Dec 22 2017, 10:48 AM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptDec 22 2017, 10:48 AM

dev_dudu.ro edited the summary of this revision. (Show Details)Dec 22 2017, 10:48 AM

dev_dudu.ro added a reviewer: lifanov.

mat added inline comments.Dec 22 2017, 12:36 PM

databases/mongodb36/Makefile
24–26	missing @${PY_FLAVOR} here.
databases/mongodb36/pkg-plist
7	This should be: @sample etc/mongodb.conf.sample

dev_dudu.ro updated this revision to Diff 36915.Dec 22 2017, 5:10 PM

dev_dudu.ro marked 2 inline comments as done.

lifanov added inline comments.Dec 27 2017, 5:08 PM

databases/mongodb36/Makefile
33	As far as I know, ports should not set CHOSEN_COMPILER_TYPE. It's set by USES=compiler. In ONLY_FOR_ARCHS=amd64 it will be clang anyway.
databases/mongodb36/files/patch-rpm_mongod.conf
22	/var/run is valid on FreeBSD. See hier(7) for which directories are available.

You need USES=shebangfix for bin/install_compass

lifanov added inline comments.Dec 27 2017, 7:45 PM

databases/mongodb36/Makefile
31	There is extra whitespace at the end of the line here.

lifanov added inline comments.Dec 27 2017, 8:54 PM

databases/mongodb36/pkg-descr
5	This redirects to https://www.mongodb.com/ You should switch WWW to the final redirect target.

lifanov added a commit: rP457783: add new port: MongoDB 3.6.0.Jan 1 2018, 4:48 PM

Hmm, I mistyped the revision URL for a second time now. I need to change my workflow for these.
I'm going to try to figure out how to close this revision.