User Details
- User Since
- May 14 2014, 3:53 AM (594 w, 1 d)
Today
Mon, Sep 29
Sun, Sep 28
The current logic looks like it was effectively rounding the elapsed time to the nearest hour (with a 30-minute bias). That means a file only 30 minutes old could be considered "1 hour old," which isn’t what a user would normally expect if they configured rotation every hour. A user would reasonably expect “1h” to mean exactly 60 minutes, with perhaps a small tolerance for cron jitter or a slow rotation run.
I like the change in general, but if I was you I'd probably use getopt_long() and call the option --signal (consider this as an optional suggestion; I don't have strong opinion with this choice), because -I was somewhat counterintuitive to me as a flag to specify signal and both -s and -S were already occupied.
Mon, Sep 22
Sun, Sep 21
Fri, Sep 19
Tue, Sep 16
Sun, Sep 14
Wed, Sep 3
For those examining the history of newsyslog(8) and the removal of the -c command-line option, I feel it's important to understand the underlying design philosophy that motivated this and related changes. The goal was to establish a more robust, flexible, and administrator-friendly configuration model.
Sep 2 2025
Aug 13 2025
Aug 11 2025
Aug 6 2025
Aug 3 2025
Aug 2 2025
Jul 27 2025
I think it makes sense to just leave compression to on (use the default, which is lz4 for the current ZFS version) instead of explicitly saying lz4 here because that would be more future proof. The change looks otherwise fine to me.
Jul 25 2025
Jul 20 2025
Jul 10 2025
Jul 2 2025
Jun 23 2025
Jun 13 2025
Jun 10 2025
Jun 2 2025
May 31 2025
Looks good to me overall, thanks for working on this! Please fix the free() operation in inline comment.
May 24 2025
May 20 2025
May 17 2025
May 10 2025
I don't have real hardware at hand but the change looks fine in principle.