Page MenuHomeFreeBSD
People bhavesh.davda_gmail.com

bhavesh.davda_gmail.com (Bhavesh Davda)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 28 2017, 5:50 PM (375 w, 6 d)

Tinkerer of myriad OSes and kernels, open source or otherwise. After all, it's only code.

Recent Activity
View All

Mar 21 2017

bhavesh.davda_gmail.com added a comment to D9832: dhclient: skip UDP checksum validation if Rx checksum offload is in effect.
In D9832#208335, @royger wrote:

Can dhclient check for the CSUM_DATA_VALID | CSUM_PSEUDO_HDR flags and just skip checking the checksum?

Mar 21 2017, 7:14 PM

Mar 17 2017

bhavesh.davda_gmail.com added a comment to D9832: dhclient: skip UDP checksum validation if Rx checksum offload is in effect.

The mbuf(9) man page specifically says this:

Mar 17 2017, 6:32 PM
bhavesh.davda_gmail.com added a comment to D9832: dhclient: skip UDP checksum validation if Rx checksum offload is in effect.

I'm contemplating withdrawing this review as I agree that usum == 0xffff is not a good test for whether the UDP checksum validation was offloaded to the NIC/driver. And @hrs this applies even if we can use SIOSGIFCAP to look for IFCAP_RXCSUM.

Mar 17 2017, 6:07 PM

Feb 28 2017

bhavesh.davda_gmail.com added a comment to D9832: dhclient: skip UDP checksum validation if Rx checksum offload is in effect.

@adrian good question. AFAICT sender sending a checksum of 0xffff would be correctly handled in the FreeBSD kernel UDP stack in udp_input()

Feb 28 2017, 10:59 PM
bhavesh.davda_gmail.com added a comment to D9832: dhclient: skip UDP checksum validation if Rx checksum offload is in effect.

There is also a related patch to the FreeBSD Xen netfront driver from Roger that goes with this patch:

Feb 28 2017, 5:55 PM