Page MenuHomeFreeBSD
Feed Advanced Search

Tue, Feb 4

harry.moulton_arm.com updated the diff for D48580: arm64: use FEAT_WFxT for DELAY() when available.

Simplify arm_tmr_do_delay() further.

Tue, Feb 4, 12:23 PM

Mon, Feb 3

harry.moulton_arm.com updated the diff for D48580: arm64: use FEAT_WFxT for DELAY() when available.

The timer register is 64-bit, so best to use *int64_t, rather than *int32_t.

Mon, Feb 3, 5:31 PM
harry.moulton_arm.com requested review of D48816: arm64: add missing feature identification to align with ARMv8.9.
Mon, Feb 3, 4:51 PM
harry.moulton_arm.com requested review of D48815: arm64: update and align armreg.h with ARMv8.9 features.
Mon, Feb 3, 4:51 PM
harry.moulton_arm.com requested review of D48814: arm64: add missing HWCAP and HWCAP2 values.
Mon, Feb 3, 4:51 PM
harry.moulton_arm.com requested review of D48813: arm64: add CHECK_CPU_FEAT() for checking feature support in assembly.
Mon, Feb 3, 4:49 PM

Wed, Jan 29

harry.moulton_arm.com updated the diff for D48580: arm64: use FEAT_WFxT for DELAY() when available.

Amended arm_tmr_do_delay() to use end for wfet(), used get_kernel_reg() rather than READ_SPECIALREG(), and added CPU_FEAT_AFTER_DEV flag, so support is checked after secondary cpus are brought up.

Wed, Jan 29, 5:53 PM
harry.moulton_arm.com updated the diff for D48580: arm64: use FEAT_WFxT for DELAY() when available.

Use the CPU feature framework to determine whether the WFxT instructions are available on all CPUs, and set enable_wfxt accordingly. When the timer is used for DELAY(), it'll check whether it can use wfet().

Wed, Jan 29, 3:19 PM

Fri, Jan 24

harry.moulton_arm.com added inline comments to D48580: arm64: use FEAT_WFxT for DELAY() when available.
Fri, Jan 24, 6:25 PM

Wed, Jan 22

harry.moulton_arm.com updated the diff for D48583: arm64: add HCRX_EL2 register.

Move configuration of hcrx_el2 to avoid trashing cptr_el2

Wed, Jan 22, 3:21 PM
harry.moulton_arm.com updated the diff for D48584: arm64/vmm: save and restore HCRX_EL2 register.

Addressed review comments

Wed, Jan 22, 2:04 PM
harry.moulton_arm.com updated the diff for D48583: arm64: add HCRX_EL2 register.

Moved HCRX register definition to hypervisor.h, moved initial
configuration of hcrx_el2 to after .Ldone_vhe

Wed, Jan 22, 2:02 PM

Tue, Jan 21

harry.moulton_arm.com added a comment to D48584: arm64/vmm: save and restore HCRX_EL2 register.

Does the value of the register matter when no guest is running? Does the hardware change the register when a guest is running? If not we can restrict when we save & restore it, e.g. if the host doesn't care what value it has, and it's never changed by hardware then we only need to restore it for guests and can drop the vmm_hyp_reg_store change.

Tue, Jan 21, 6:35 PM
harry.moulton_arm.com requested review of D48584: arm64/vmm: save and restore HCRX_EL2 register.
Tue, Jan 21, 5:47 PM
harry.moulton_arm.com requested review of D48583: arm64: add HCRX_EL2 register.
Tue, Jan 21, 5:47 PM
harry.moulton_arm.com updated the diff for D48579: arm64: add inline functions for FEAT_WFxT instructions.

Cast to uint64_t not needed, removed.

Tue, Jan 21, 5:40 PM
harry.moulton_arm.com requested review of D48578: arm64: add HWCAP for FEAT_WFxT.
Tue, Jan 21, 3:21 PM
harry.moulton_arm.com requested review of D48580: arm64: use FEAT_WFxT for DELAY() when available.
Tue, Jan 21, 3:21 PM
harry.moulton_arm.com requested review of D48579: arm64: add inline functions for FEAT_WFxT instructions.
Tue, Jan 21, 3:21 PM
harry.moulton_arm.com requested review of D48577: arm64: fix ID_AA64ISAR2_WFxT_IMPL value.
Tue, Jan 21, 3:20 PM