Page MenuHomeFreeBSD
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Fri, Jun 21

jtl added a comment to D45411: tcp: simplify endpoint creation at the passive side.

Thanks! I like this approach. I've added a few comments about potential enhancements.

Fri, Jun 21, 11:35 PM

Fri, May 31

jtl accepted D45425: tcp: in tcp_close() call tcp_timer_stop() after pcb has been dropped.
Fri, May 31, 6:24 PM
jtl added a comment to D45411: tcp: simplify endpoint creation at the passive side.
In D45411#1036082, @tuexen wrote:
In D45411#1035980, @jtl wrote:

Should we check for TCP_FUNC_BEING_REMOVED?

I thought about this and did again after you raised the question. The original code didn't.
...
However, since we don't hold the tcp_function_lock, the tfb can be removed any time before or after we set the TCP function block in tcp_newtcpcb. It cannot go away, since we hold a reference count. I guess that is the reason why there was no check...

Fri, May 31, 3:51 PM
jtl added a comment to D45419: tcp: mark TCP stacks which can serve as a default stack.

Can you give a brief explanation of the problem this is supposed to solve?

Fri, May 31, 3:18 PM

Thu, May 30

jtl added a comment to D45411: tcp: simplify endpoint creation at the passive side.

Should we check for TCP_FUNC_BEING_REMOVED?

Thu, May 30, 7:52 PM
Next