Page MenuHomeFreeBSD
Feed Advanced Search

Feb 5 2024

pldrouin_gmail.com updated the diff for D43746: Adding Support for QorIQ LX2160A I2C Controller.

-Moved the source files to sys/dev/iicbus/controller/qoriq
-Removed lx2160a_common.h
-Renamed the driver modules to separate names
-Now using wait_for_nibb in i2c_start so it works reliably after a reset
-Added the drivers to files.arm64
-Updated the copyright notice, and added credits.

Feb 5 2024, 2:32 PM · arm64, ARM
pldrouin_gmail.com added a comment to D43746: Adding Support for QorIQ LX2160A I2C Controller.

Thanks, I will make these changes. I also have to tweak some delay that should apply when a start follows a reset.

Feb 5 2024, 1:04 PM · arm64, ARM
pldrouin_gmail.com added a comment to D43746: Adding Support for QorIQ LX2160A I2C Controller.

Ok I have found a few things to change. It looks like some extra delays might be required when the module is not run in DEBUG mode.

Feb 5 2024, 4:47 AM · arm64, ARM
pldrouin_gmail.com added a comment to D43746: Adding Support for QorIQ LX2160A I2C Controller.

I currently have it configured as a pair of modules. One weird thing I noticed is that I could kldload and kldunload them just fine when I was building the modules manually and before I included them in sys/modules/Makefile and I rebuilt the kernel. After adding them to sys/modules/Makefile, rebuilding and installing the kernel, I can only load them through /boot/loader.conf, otherwise it complains the modules are already loaded in the kernel, although kldstat -v and grep -R lx2160a_i2c /boot/kernel say otherwise. How can this be fixed? Thanks

Feb 5 2024, 4:13 AM · arm64, ARM
pldrouin_gmail.com updated the test plan for D43746: Adding Support for QorIQ LX2160A I2C Controller.
Feb 5 2024, 4:02 AM · arm64, ARM
pldrouin_gmail.com updated the test plan for D43746: Adding Support for QorIQ LX2160A I2C Controller.
Feb 5 2024, 4:01 AM · arm64, ARM
pldrouin_gmail.com requested review of D43746: Adding Support for QorIQ LX2160A I2C Controller.
Feb 5 2024, 4:00 AM · arm64, ARM

Feb 4 2024

pldrouin_gmail.com added a comment to D24917: Add ACPI attachment for the Vybrid VF610 I2C controller.

I wrote a FDT/ACPI split driver for the LX2160A I2C controller based on the work started by Val, and the LX2160A I2C controller documentation. It deviates significantly from the Vybrid driver as the way the original driver was handling the controller's registers was not quite compatible with the LX2160A I2C controller. Should I start a new diff with my driver and link to it from here? It seems to work well so far based on the (limited) tests I made. I can scan the bus and get the correct output. I am able to query the MUX's register and the fan controller's ID.

Feb 4 2024, 6:30 PM · arm64, ARM