One could argue that simply testing for !nosignal is enough here (line 336). If the daemon(s) is(are) not being signaled then what good does the sleep "to allow daemon(s) to close log file(s)" do since the daemon(s) is(are) not being informed of the rotation? However, I started with the conservative approach.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 5 2016
Jun 5 2016
Jun 4 2016
Jun 4 2016
dab added a comment to D6727: Eliminate unnecessary sleep(10) in newsyslog when -R and -s are specified.
dab updated the diff for D6727: Eliminate unnecessary sleep(10) in newsyslog when -R and -s are specified.
No changes to actual diff; just trying to get context (pardon my unfamiliarity with phabricator).
dab added a reviewer for D6727: Eliminate unnecessary sleep(10) in newsyslog when -R and -s are specified: vangyzen.
dab retitled D6727: Eliminate unnecessary sleep(10) in newsyslog when -R and -s are specified from to Eliminate unnecessary sleep(10) in newsyslog when -R and -s are specified.