Page MenuHomeFreeBSD

dtrace: Disable getf() as it is broken on FreeBSD.
ClosedPublic

Authored by domagoj.stolfa_gmail.com on Dec 10 2021, 7:26 PM.
Tags
None
Referenced Files
F167627393: D33378.id100220.diff
Sun, Aug 23, 7:29 AM
F167626596: D33378.id.diff
Sun, Aug 23, 7:18 AM
F167594729: D33378.diff
Sat, Aug 22, 11:44 PM
Unknown Object (File)
Fri, Aug 21, 11:04 AM
Unknown Object (File)
Fri, Aug 21, 11:03 AM
Unknown Object (File)
Fri, Aug 21, 11:02 AM
Unknown Object (File)
Sat, Aug 15, 1:09 AM
Unknown Object (File)
Tue, Aug 11, 10:18 PM
Subscribers

Details

Summary

getf() on FreeBSD calls _sx_slock(), _sx_sunlock() and fget_locked().
Furthermore, it does not set the per-core fault flag, meaning it
usually ends up in a double fault panic once getf() does get called,
especially from fbt.

Reviewing the DTrace Toolkit + a number of other scripts scattered
around FreeBSD, I have not been able to find one use of getf(). Given
how broken the implementation currently is, we disable it until it
can be implemented properly.

Also comment out a test in aggs/tst.subr.d for getf().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 43282
Build 40170: arc lint + arc unit