Page MenuHomeFreeBSD

dtrace: Disable getf() as it is broken on FreeBSD.
ClosedPublic

Authored by domagoj.stolfa_gmail.com on Dec 10 2021, 7:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 28, 10:02 PM
Unknown Object (File)
Sun, Apr 19, 1:58 PM
Unknown Object (File)
Sat, Apr 18, 5:51 PM
Unknown Object (File)
Wed, Apr 15, 12:47 PM
Unknown Object (File)
Sun, Apr 12, 2:08 AM
Unknown Object (File)
Sun, Apr 5, 4:38 PM
Unknown Object (File)
Mar 30 2026, 4:46 PM
Unknown Object (File)
Mar 30 2026, 8:25 AM
Subscribers

Details

Summary

getf() on FreeBSD calls _sx_slock(), _sx_sunlock() and fget_locked().
Furthermore, it does not set the per-core fault flag, meaning it
usually ends up in a double fault panic once getf() does get called,
especially from fbt.

Reviewing the DTrace Toolkit + a number of other scripts scattered
around FreeBSD, I have not been able to find one use of getf(). Given
how broken the implementation currently is, we disable it until it
can be implemented properly.

Also comment out a test in aggs/tst.subr.d for getf().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 43282
Build 40170: arc lint + arc unit