Page MenuHomeFreeBSD
Differential D32506

kldstat(8): style(9) fix
ClosedPublic
Actions

Authored by christos on Oct 15 2021, 12:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 30, 11:07 AM
Unknown Object (File)
Sat, May 18, 10:12 PM
Unknown Object (File)
Fri, May 10, 8:04 AM
Unknown Object (File)
May 7 2024, 10:57 AM
Unknown Object (File)
May 7 2024, 7:55 AM
Unknown Object (File)
Apr 26 2024, 1:18 AM
Unknown Object (File)
Apr 26 2024, 1:17 AM
Unknown Object (File)
Apr 26 2024, 1:17 AM
View All 64 Files
Subscribers
imp

Details

Reviewers
• hselasky
imp
Commits
rGd7c7e033dad0: kldstat(8): style(9) fixes.
rG83237efcdbc1: kldstat(8): style(9) fixes.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Oct 15 2021, 12:26 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 15 2021, 12:26 PM
christos requested review of this revision.Oct 15 2021, 12:26 PM
christos added a parent revision: D32502: kldstat(8): Fix indentation.
christos updated this revision to Diff 96904.Oct 15 2021, 1:03 PM

Include whole file in diff.

christos added a reviewer: imp.Oct 16 2021, 11:43 AM
christos updated this revision to Diff 97299.Oct 22 2021, 2:52 PM

Add braces to getopt loop.

• hselasky added inline comments.Nov 9 2021, 9:03 PM
sbin/kldstat/kldstat.c
32

I think these headers where correctly sorted. Can you explain your changes a bit more?

christos added inline comments.Nov 10 2021, 11:57 AM
sbin/kldstat/kldstat.c
32

According to style(9), <sys/*.h> headers have to come first.

• hselasky added inline comments.Nov 10 2021, 2:10 PM
sbin/kldstat/kldstat.c
63

I think multi-line statements should have {}'s around them. Here you've omitted them.

christos updated this revision to Diff 98311.Nov 10 2021, 2:25 PM

Added braces to multiline printf statements.

christos marked 2 inline comments as done.Nov 10 2021, 2:25 PM
christos added inline comments.
sbin/kldstat/kldstat.c
63

Fixed.

christos retitled this revision from kldstat(8): Minor code changes to kldstat(8): style(9) fix.Nov 10 2021, 2:40 PM
christos edited the summary of this revision. (Show Details)
• hselasky accepted this revision.Dec 7 2021, 10:31 AM
This revision is now accepted and ready to land.Dec 7 2021, 10:31 AM
Closed by commit rG83237efcdbc1: kldstat(8): style(9) fixes. (authored by • hselasky). · Explain WhyDec 7 2021, 10:42 AM
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rG83237efcdbc1: kldstat(8): style(9) fixes..
• hselasky added a commit: rGd7c7e033dad0: kldstat(8): style(9) fixes..Jan 7 2022, 1:31 PM

Revision Contents
Changeset List

PathSize
sbin/
kldstat/
107 lines

Diff 99647

View Options

sbin/kldstat/kldstat.c

Loading...