Page MenuHomeFreeBSD

kldstat(8): style(9) fix
ClosedPublic

Authored by christos on Oct 15 2021, 12:26 PM.
Tags
None
Referenced Files
F133196063: D32506.id.diff
Thu, Oct 23, 9:11 PM
Unknown Object (File)
Sat, Oct 18, 11:54 PM
Unknown Object (File)
Sat, Oct 18, 11:31 AM
Unknown Object (File)
Fri, Oct 17, 1:51 AM
Unknown Object (File)
Fri, Oct 17, 1:25 AM
Unknown Object (File)
Thu, Oct 16, 5:23 PM
Unknown Object (File)
Wed, Oct 15, 7:01 PM
Unknown Object (File)
Wed, Oct 15, 6:12 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Include whole file in diff.

sbin/kldstat/kldstat.c
32

I think these headers where correctly sorted. Can you explain your changes a bit more?

sbin/kldstat/kldstat.c
32

According to style(9), <sys/*.h> headers have to come first.

sbin/kldstat/kldstat.c
63

I think multi-line statements should have {}'s around them. Here you've omitted them.

Added braces to multiline printf statements.

christos added inline comments.
sbin/kldstat/kldstat.c
63

Fixed.

christos retitled this revision from kldstat(8): Minor code changes to kldstat(8): style(9) fix.Nov 10 2021, 2:40 PM
christos edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Dec 7 2021, 10:31 AM
This revision was automatically updated to reflect the committed changes.