fb: Remove unused FBIOSVIDEO/FBIOGVIDEO ioctls
ClosedPublic
Actions

Authored by manu on Dec 1 2021, 2:22 PM.

Details

Reviewers

emaste
imp
tsoome

Commits

rGcc723136640a: fb: Remove unused FBIOSVIDEO/FBIOGVIDEO ioctls
rG26542b33a4d5: fb: Remove unused FBIOSVIDEO/FBIOGVIDEO ioctls

Summary

The FBIOSVIDEO/FBIOGVIDEO ioctls were added in 1994 with the 4.4 Lite import
but were never implemented in either sc(4), fb(4) or vt(4).
Remove it.

MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43090
Build 39978: arc lint + arc unit

Event Timeline

manu created this revision.Dec 1 2021, 2:22 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptDec 1 2021, 2:22 PM

manu requested review of this revision.Dec 1 2021, 2:22 PM

Harbormaster completed remote builds in B43090: Diff 99297.Dec 1 2021, 2:22 PM

manu added a parent revision: D33215: fb: Remove unused FBIOSATTR/FBIOGATTR ioctls.Dec 1 2021, 2:22 PM

manu added reviewers: emaste, imp, tsoome.Dec 1 2021, 2:25 PM

Not relevant for FreeBSD.

Similar to D33215 seems to be implemented in NetBSD for various sun/sparc hardware e.g.

sys/arch/sparc64/dev/ffb.c:             return ffb_blank(sc, cmd == FBIOGVIDEO?
sys/arch/sun3/dev/bw2.c:/* FBIOGVIDEO: */
...

This revision is now accepted and ready to land.Dec 1 2021, 3:17 PM

tsoome accepted this revision.Dec 1 2021, 4:01 PM

I'll pick this as a random one to comment on: If you have all these 'remove old ioctl' commits on a branch, it wouldn't hurt to do an i386 exp run to see if there's any hidden users of these because of $OTHERSYSTEMS and it just compiling (even if it did nothing or failed when called).

Closed by commit rG26542b33a4d5: fb: Remove unused FBIOSVIDEO/FBIOGVIDEO ioctls (authored by manu). · Explain WhyDec 6 2021, 10:30 AM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG26542b33a4d5: fb: Remove unused FBIOSVIDEO/FBIOGVIDEO ioctls.

manu added a commit: rGcc723136640a: fb: Remove unused FBIOSVIDEO/FBIOGVIDEO ioctls.Dec 21 2021, 9:22 AM