acpi: fix device_get_property invalid return
ClosedPublic
Actions

Authored by bag_semihalf.com on Nov 24 2021, 8:09 AM.

Details

Reviewers

mw
wma
bz

Commits

rGd9ed1dcc5c68: acpi: Fix error code returned in acpi_bus_get_prop

Summary

Previously ACPI implementation of device_get_property returned -1
when property was found, but it's type was not supported. This caused
device_has_property to return false in that scenario, which is
incorrect.

From now on, ACPI's device_get_property will return 0, when property type
is not unrecognized.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bag_semihalf.com created this revision.Nov 24 2021, 8:09 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 24 2021, 8:09 AM

bag_semihalf.com requested review of this revision.Nov 24 2021, 8:09 AM

Thanks for doing this!

This revision is now accepted and ready to land.Nov 24 2021, 3:45 PM

Tested on: CN913x CEx7 Evaluation Board.

Closed by commit rGd9ed1dcc5c68: acpi: Fix error code returned in acpi_bus_get_prop (authored by bag_semihalf.com, committed by mw). · Explain WhyNov 24 2021, 6:43 PM

This revision was automatically updated to reflect the committed changes.

mw added a commit: rGd9ed1dcc5c68: acpi: Fix error code returned in acpi_bus_get_prop.

mw mentioned this in rG45b49a0f96e0: device: add device_get_property and device_has_property.Mar 29 2022, 11:00 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi.c

5 lines

Diff 98964

View Options

acpi: fix device_get_property invalid returnClosedPublicActions