Page MenuHomeFreeBSD
Differential D33077

tzsetup
ClosedPublic
Actions

Authored by bapt on Nov 22 2021, 10:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 31, 8:04 PM
Unknown Object (File)
Oct 28 2025, 5:14 AM
Unknown Object (File)
Oct 15 2025, 11:09 AM
Unknown Object (File)
Oct 15 2025, 11:09 AM
Unknown Object (File)
Oct 15 2025, 11:09 AM
Unknown Object (File)
Oct 15 2025, 11:09 AM
Unknown Object (File)
Oct 15 2025, 12:13 AM
Unknown Object (File)
Oct 8 2025, 3:39 AM
View All Files
Subscribers
imp

Details

Reviewers
asiciliano
Commits
rGf872dde34c6a: tzsetup: replace libdialog with libbsddialog
Summary

Rework to use bsddialog

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42914
Build 39802: arc lint + arc unit

Event Timeline

bapt created this revision.Nov 22 2021, 10:37 AM
Herald added a subscriber: imp. · View Herald TranscriptNov 22 2021, 10:37 AM
bapt requested review of this revision.Nov 22 2021, 10:37 AM
Harbormaster completed remote builds in B42913: Diff 98829.Nov 22 2021, 10:37 AM
bapt updated this revision to Diff 98831.Nov 22 2021, 1:35 PM

catchup with bsddialog_initconf

Harbormaster completed remote builds in B42914: Diff 98831.Nov 22 2021, 1:36 PM
asiciliano added a comment.Nov 22 2021, 7:57 PM

I changed the api, sorry, you should change
terminalwidth() -> bsddialog_terminalwidth();
terminalwidth(); -> bsddialog_terminalwidth();
if (listitems[i].on == 'X') -> if (listitems[i].on == true)
Now warnings are fixed.

Important: "Bus error (core dump)", to reproduce:
<NO> -> Europe -> Italy -> <No> -> <Cancel>

I am investigating

usr.sbin/tzsetup/tzsetup.c
151

bsddialog_terminalheight())

152

bsddialog_terminalheight())

172

bsddialog_terminalwidth())

173

bsddialog_terminalwidth();

181

if (listitems[i].on == true)

asiciliano accepted this revision.Nov 22 2021, 11:28 PM
asiciliano added inline comments.
usr.sbin/tzsetup/tzsetup.c
139

This fix the overflow:
listitems = calloc(item_no + 1, sizeof(struct bsddialog_menuitem));

145

To be sure, I would add also:

listitems[i].depth = 0;
listitems[i].bottomdesc = "";
listitems[i].on = false;

This revision is now accepted and ready to land.Nov 22 2021, 11:28 PM
asiciliano added a comment.Nov 23 2021, 2:52 AM

Important:
Please, for now use

terminalheight() - 2

and

terminalwidth() -3

to fix a silent error (unpleasant consequence: the enter key has not effect with long menus)

I am going to write documented functions:
getwidget_height()/width() (they already exist but as internal utils).
Sorry for the fix after the "Accept"

usr.sbin/tzsetup/tzsetup.c
151

fix
if (height > terminalheight() -2)

152

fix
bsddialog_terminalheight() -2;

172

if (width > terminalwidth() -3)

173

width = terminalwidth() -3;

Closed by commit rGf872dde34c6a: tzsetup: replace libdialog with libbsddialog (authored by bapt). · Explain WhyNov 24 2021, 10:05 AM
This revision was automatically updated to reflect the committed changes.
bapt added a commit: rGf872dde34c6a: tzsetup: replace libdialog with libbsddialog.

Revision Contents
Changeset List

PathSize
usr.sbin/
tzsetup/
155 lines

Diff 98831

View Options

usr.sbin/tzsetup/tzsetup.c

Loading...