ext2fs: check for eh_depth in ext4_ext_check_header()
ClosedPublic
Actions

Authored by nc on Nov 17 2021, 12:26 AM.

Details

Reviewers

kib
mjg
fsu

Commits

rG8facf7082d49: ext2fs: check for eh_depth in ext4_ext_check_header()
rG5c50e93e6ce4: ext2fs: check for eh_depth in ext4_ext_check_header()
rGbe60d8f276fa: ext2fs: check for eh_depth in ext4_ext_check_header()

Summary

PR: 259112
Reported by: Robert Morris <rtm@lcs.mit.edu>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42832
Build 39720: arc lint + arc unit

Event Timeline

nc created this revision.Nov 17 2021, 12:26 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 17 2021, 12:26 AM

nc requested review of this revision.Nov 17 2021, 12:26 AM

Harbormaster completed remote builds in B42832: Diff 98626.Nov 17 2021, 12:26 AM

I am working on more complex extents verification logic, but let it to be committed.

Also:
https://github.com/torvalds/linux/blob/master/fs/ext4/extents.c#L467

	if (unlikely(depth > 32)) {
		error_msg = "too large eh_depth";
		goto corrupted;
	}

This revision is now accepted and ready to land.Nov 18 2021, 10:33 AM

Closed by commit rGbe60d8f276fa: ext2fs: check for eh_depth in ext4_ext_check_header() (authored by nc). · Explain WhyNov 18 2021, 5:54 PM

This revision was automatically updated to reflect the committed changes.

nc added a commit: rGbe60d8f276fa: ext2fs: check for eh_depth in ext4_ext_check_header().

nc added a commit: rG5c50e93e6ce4: ext2fs: check for eh_depth in ext4_ext_check_header().Nov 29 2021, 5:57 PM

nc added a commit: rG8facf7082d49: ext2fs: check for eh_depth in ext4_ext_check_header().

Revision Contents
Changeset List

Path

Size

sys/

fs/

ext2fs/

ext2_extents.c

4 lines

Diff 98626

View Options

sys/fs/ext2fs/ext2_extents.c

ext2fs: check for eh_depth in ext4_ext_check_header()ClosedPublicActions