ext2fs: check for eh_depth in ext4_ext_check_header()
ClosedPublic
Actions

Authored by nc on Nov 17 2021, 12:26 AM.

Details

Reviewers

kib
mjg
fsu

Commits

rG8facf7082d49: ext2fs: check for eh_depth in ext4_ext_check_header()
rG5c50e93e6ce4: ext2fs: check for eh_depth in ext4_ext_check_header()
rGbe60d8f276fa: ext2fs: check for eh_depth in ext4_ext_check_header()

Summary

PR: 259112
Reported by: Robert Morris <rtm@lcs.mit.edu>

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42832
Build 39720: arc lint + arc unit

Event Timeline

nc created this revision.Nov 17 2021, 12:26 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 17 2021, 12:26 AM

nc requested review of this revision.Nov 17 2021, 12:26 AM

Harbormaster completed remote builds in B42832: Diff 98626.Nov 17 2021, 12:26 AM

I am working on more complex extents verification logic, but let it to be committed.

Also:
https://github.com/torvalds/linux/blob/master/fs/ext4/extents.c#L467

	if (unlikely(depth > 32)) {
		error_msg = "too large eh_depth";
		goto corrupted;
	}

This revision is now accepted and ready to land.Nov 18 2021, 10:33 AM

Closed by commit rGbe60d8f276fa: ext2fs: check for eh_depth in ext4_ext_check_header() (authored by nc). · Explain WhyNov 18 2021, 5:54 PM

This revision was automatically updated to reflect the committed changes.

nc added a commit: rGbe60d8f276fa: ext2fs: check for eh_depth in ext4_ext_check_header().

nc added a commit: rG5c50e93e6ce4: ext2fs: check for eh_depth in ext4_ext_check_header().Nov 29 2021, 5:57 PM

nc added a commit: rG8facf7082d49: ext2fs: check for eh_depth in ext4_ext_check_header().

Revision Contents
Changeset List

Path

Size

sys/

fs/

ext2fs/

ext2_extents.c

4 lines

Diff 98626

View Options

sys/fs/ext2fs/ext2_extents.c

	Show First 20 Lines • Show All 95 Lines • ▼ Show 20 Lines
	bootenv_autolist="YES" # Auto populate the list of ZFS Boot Environments			bootenv_autolist="YES" # Auto populate the list of ZFS Boot Environments
	#beastie_disable="NO" # Turn the beastie boot menu on and off			#beastie_disable="NO" # Turn the beastie boot menu on and off
	efi_max_resolution="1x1" # Set the max resolution for EFI loader to use:			efi_max_resolution="1x1" # Set the max resolution for EFI loader to use:
	# 480p, 720p, 1080p, 2160p/4k, 5k, or specify			# 480p, 720p, 1080p, 2160p/4k, 5k, or specify
	# WidthxHeight (e.g. 1920x1080)			# WidthxHeight (e.g. 1920x1080)
	#kernels="kernel kernel.old" # Kernels to display in the boot menu			#kernels="kernel kernel.old" # Kernels to display in the boot menu
	kernels_autodetect="YES" # Auto-detect kernel directories in /boot			kernels_autodetect="YES" # Auto-detect kernel directories in /boot
	#loader_logo="orbbw" # Desired logo: orbbw, orb, fbsdbw, beastiebw, beastie, none			#loader_logo="orbbw" # Desired logo: orbbw, orb, fbsdbw, beastiebw, beastie, none
	#comconsole_speed="9600" # Set the current serial console speed			#comconsole_speed="115200" # Set the current serial console speed
	#console="vidconsole" # A comma separated list of console(s)			#console="vidconsole" # A comma separated list of console(s)
	#currdev="disk1s1a" # Set the current device			#currdev="disk1s1a" # Set the current device
	module_path="/boot/modules;/boot/dtb;/boot/dtb/overlays" # Set the module search path			module_path="/boot/modules;/boot/dtb;/boot/dtb/overlays" # Set the module search path
	module_blacklist="drm drm2 radeonkms i915kms amdgpu" # Loader module blacklist			module_blacklist="drm drm2 radeonkms i915kms amdgpu" # Loader module blacklist
	#prompt="\\${interpret}" # Set the command prompt			#prompt="\\${interpret}" # Set the command prompt
	#root_disk_unit="0" # Force the root disk unit number			#root_disk_unit="0" # Force the root disk unit number
	#rootdev="disk1s1a" # Set the root filesystem			#rootdev="disk1s1a" # Set the root filesystem
	#dumpdev="disk1s1b" # Set a dump device early in the boot process			#dumpdev="disk1s1b" # Set a dump device early in the boot process
	▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines

ext2fs: check for eh_depth in ext4_ext_check_header()ClosedPublicActions