crypto: Don't assert on valid IV length for Chacha20-Poly1305.
ClosedPublic
Actions

Authored by jhb on Nov 5 2021, 10:37 PM.

Details

Reviewers

Commits

rG7ec9f24cdb88: crypto: Don't assert on valid IV length for Chacha20-Poly1305.
rG442ad83e38e8: crypto: Don't assert on valid IV length for Chacha20-Poly1305.

Summary

The assertion checking for valid IV lengths added in 1833d6042c9a
was not properly updated to permit an IV length of 8 in commit
42dcd39528c6.

Reported by: syzbot+f0c0559b8be1d6eb28c7@syzkaller.appspotmail.com
Fixes: 42dcd39528c6 crypto: Support Chacha20-Poly1305 with a nonce size of 8 bytes.
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 5 2021, 10:37 PM

Herald added subscribers: jmg, imp. · View Herald TranscriptNov 5 2021, 10:37 PM

jhb requested review of this revision.Nov 5 2021, 10:37 PM

Harbormaster completed remote builds in B42621: Diff 98098.Nov 5 2021, 10:37 PM

Tested via cryptocheck -a chacha20-poly1305 -I 8 -d soft

markj accepted this revision.Nov 7 2021, 8:21 PM

This revision is now accepted and ready to land.Nov 7 2021, 8:21 PM

Closed by commit rG442ad83e38e8: crypto: Don't assert on valid IV length for Chacha20-Poly1305. (authored by jhb). · Explain WhyNov 9 2021, 6:54 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG442ad83e38e8: crypto: Don't assert on valid IV length for Chacha20-Poly1305..

jhb added a commit: rG7ec9f24cdb88: crypto: Don't assert on valid IV length for Chacha20-Poly1305..Nov 23 2021, 11:13 PM

Revision Contents
Changeset List

Path

Size

sys/

opencrypto/

xform_chacha20_poly1305.c

2 lines

Diff 98266

View Options

sys/opencrypto/xform_chacha20_poly1305.c

crypto: Don't assert on valid IV length for Chacha20-Poly1305.ClosedPublicActions