Page MenuHomeFreeBSD
Differential D32821

fexecve(2): allow O_PATH file descriptors opened without O_EXEC
ClosedPublic
Actions

Authored by kib on Nov 3 2021, 1:33 PM.
Tags
None
Referenced Files
F111303017: D32821.id97952.diff
Sun, Mar 2, 2:11 AM
F111299130: D32821.diff
Sun, Mar 2, 1:03 AM
Unknown Object (File)
Sun, Feb 23, 11:58 AM
Unknown Object (File)
Sun, Feb 23, 6:39 AM
Unknown Object (File)
Fri, Feb 14, 7:44 AM
Unknown Object (File)
Fri, Feb 14, 7:35 AM
Unknown Object (File)
Fri, Feb 14, 7:25 AM
Unknown Object (File)
Tue, Feb 11, 2:46 AM
View All 60 Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rGbe10c0a91015: fexecve(2): allow O_PATH file descriptors opened without O_EXEC
Summary

This improves compatibility with Linux.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Nov 3 2021, 1:33 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 3 2021, 1:33 PM
kib requested review of this revision.Nov 3 2021, 1:33 PM
markj accepted this revision.Nov 3 2021, 2:47 PM
markj added inline comments.
sys/kern/kern_exec.c
552
558

Can this logic live in fgetvp_exec()? Note that that function is unused after this change.

This revision is now accepted and ready to land.Nov 3 2021, 2:47 PM
kib updated this revision to Diff 97950.Nov 3 2021, 3:17 PM
kib marked 2 inline comments as done.

Move O_PATH check into fgetvp_exec().

This revision now requires review to proceed.Nov 3 2021, 3:17 PM
markj accepted this revision.Nov 3 2021, 3:41 PM
This revision is now accepted and ready to land.Nov 3 2021, 3:41 PM
Closed by commit rGbe10c0a91015: fexecve(2): allow O_PATH file descriptors opened without O_EXEC (authored by kib). · Explain WhyNov 3 2021, 4:03 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGbe10c0a91015: fexecve(2): allow O_PATH file descriptors opened without O_EXEC.

Revision Contents
Changeset List

PathSize
lib/
libc/
sys/
3 lines
sys/
kern/
5 lines
13 lines

Diff 97950

View Options

lib/libc/sys/open.2

Loading...
View Options

sys/kern/kern_descrip.c

Loading...
View Options

sys/kern/kern_exec.c

Loading...