Page MenuHomeFreeBSD
Differential D32745

devctl: Add DEV_GET_PATH
ClosedPublic
Actions

Authored by imp on Oct 30 2021, 12:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 2:00 PM
Unknown Object (File)
Mar 23 2024, 6:15 AM
Unknown Object (File)
Mar 23 2024, 6:15 AM
Unknown Object (File)
Mar 23 2024, 6:15 AM
Unknown Object (File)
Mar 23 2024, 6:15 AM
Unknown Object (File)
Mar 23 2024, 6:15 AM
Unknown Object (File)
Mar 23 2024, 6:15 AM
Unknown Object (File)
Mar 22 2024, 11:36 PM
View All 31 Files
Subscribers
None

Details

Reviewers
jhb
Commits
rG38e942a3452f: devctl: Add DEV_GET_PATH
Summary

DEV_GET_PATH will get the path to a device based on different locators.

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42501
Build 39389: arc lint + arc unit

Event Timeline

imp requested review of this revision.Oct 30 2021, 12:52 AM
imp created this revision.
Harbormaster completed remote builds in B42446: Diff 97723.Oct 30 2021, 12:52 AM
imp added a parent revision: D32744: bus: Introduce the bus interface get_device_path.Oct 30 2021, 12:52 AM
imp added a child revision: D32746: libdevctl: Add devctl_getpath.
imp added a reviewer: jhb.Oct 30 2021, 12:53 AM
imp updated this revision to Diff 97828.Nov 1 2021, 7:23 PM

refactor to make things easier later.

Harbormaster completed remote builds in B42501: Diff 97828.Nov 1 2021, 7:23 PM
imp updated this revision to Diff 97932.Nov 3 2021, 1:55 PM

rebase + ping

Harbormaster completed remote builds in B42545: Diff 97932.Nov 3 2021, 1:55 PM
jhb added inline comments.Nov 4 2021, 9:14 PM
sys/kern/subr_bus.c
5710

I would maybe just make this return a char *. It's a static function and the caller has to pass the result to free anyway, so it's always going to require an ugly __DECONST in the caller to deal with free. Doing this removes the __DECONST below in the ioctl handler and also removes the need for both rv and r in this function.

5721

Hmm, I guess sbuf_finish() can't fail in practice due to SBUF_AUTOEXTEND?

5731
5757

I would be fine with not requiring PRIV_DRIVER for this request.

imp added a parent revision: D32863: devctl2: Change to 644 protections.Nov 5 2021, 11:15 PM
imp marked 4 inline comments as done.

Updated based on review.

sys/kern/subr_bus.c
5710

OK.

5721

Doesn't matter if it fails or not. If it does fail, len will be -1, which is checked below.

5757

OK. /dev/devctl2's permissions would need to be updated for that to be completely useful though.

imp updated this revision to Diff 98102.Nov 5 2021, 11:17 PM
imp marked 3 inline comments as done.

update based on review

Harbormaster completed remote builds in B42624: Diff 98102.Nov 5 2021, 11:17 PM
jhb accepted this revision.Nov 9 2021, 5:29 PM
This revision is now accepted and ready to land.Nov 9 2021, 5:29 PM
Closed by commit rG38e942a3452f: devctl: Add DEV_GET_PATH (authored by imp). · Explain WhyMar 1 2022, 3:43 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG38e942a3452f: devctl: Add DEV_GET_PATH.

Revision Contents
Changeset List

PathSize
sys/
kern/
48 lines
sys/
1 line

Diff 97828

View Options

sys/kern/subr_bus.c

Loading...
View Options

sys/sys/bus.h

Loading...