Page MenuHomeFreeBSD
Differential D32722

libnv: read entire datagram in nvlist_recv()
ClosedPublic
Actions

Authored by rew on Oct 29 2021, 12:31 AM.
Tags
None
Referenced Files
F105262732: D32722.id97788.diff
Sat, Dec 14, 5:06 AM
F105261197: D32722.id97789.diff
Sat, Dec 14, 4:38 AM
Unknown Object (File)
Tue, Dec 10, 5:17 AM
Unknown Object (File)
Sat, Nov 23, 2:26 PM
Unknown Object (File)
Sat, Nov 23, 2:22 PM
Unknown Object (File)
Oct 21 2024, 12:14 AM
Unknown Object (File)
Oct 19 2024, 1:22 PM
Unknown Object (File)
Oct 3 2024, 4:38 PM
View All 81 Files
Subscribers
imp
lwhsu

Details

Reviewers
oshogbo
Commits
rG5916ae1fb14a: libnv: read entire datagram in nvlist_recv()
Summary

When SOCK_DGRAM is used, a portion of the datagram is discarded during
the initial recv() when getting the nvlist_header.

To workaround this, use MSG_PEEK for the initial recv() when using a
datagram socket.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42481
Build 39369: arc lint + arc unit

Event Timeline

rew created this revision.Oct 29 2021, 12:31 AM
Herald added a subscriber: imp. · View Herald TranscriptOct 29 2021, 12:31 AM
rew requested review of this revision.Oct 29 2021, 12:31 AM
Harbormaster completed remote builds in B42430: Diff 97644.Oct 29 2021, 12:32 AM
rew added a parent revision: D32721: libnv: allow passing flags argument to recv().Oct 29 2021, 12:32 AM
rew added a reviewer: oshogbo.Oct 29 2021, 12:36 AM
oshogbo added a comment.Oct 29 2021, 9:07 AM

Could you also add test for this case?

rew updated this revision to Diff 97788.Nov 1 2021, 7:23 AM

add ATF tests for SOCK_DGRAM with nvlist_send()/nvlist_recv().

The test-case nvlist_send_recv__send_many_fds_dgram, wouldn't pass
without sysctl tuning. Specifically, net.local.dgram.maxdgram and
net.local.dgram.recvspace.

Not sure if this test should be enabled by default.

Harbormaster completed remote builds in B42480: Diff 97788.Nov 1 2021, 7:23 AM
rew updated this revision to Diff 97789.Nov 1 2021, 7:30 AM

remove blank line

Harbormaster completed remote builds in B42481: Diff 97789.Nov 1 2021, 7:30 AM
oshogbo added a subscriber: lwhsu.Nov 3 2021, 4:12 PM

@lwhsu Is those settings ok with our tests machines?

rew added a comment.Nov 15 2021, 6:08 PM

ping @lwhsu

Let me know if there's anything I can do to help to get these tests in.

If the settings are unacceptable for the test machines, I can atf_skip the offending test.

Just to be clear, I've added 3 tests - and only the one test-case needs sysctl tuning to pass.

rew added a comment.Nov 20 2021, 7:45 PM

Any objections here?

If I don't hear back from @lwhsu , I'll disable the nvlist_send_recv__send_many_fds__dgram test case on commit.

oshogbo added a comment.Nov 22 2021, 1:31 PM

Feel free to commit this.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 6 2021, 6:58 PM
Closed by commit rG5916ae1fb14a: libnv: read entire datagram in nvlist_recv() (authored by rew). · Explain Why
This revision was automatically updated to reflect the committed changes.
rew added a commit: rG5916ae1fb14a: libnv: read entire datagram in nvlist_recv().

Revision Contents
Changeset List

PathSize
lib/
libnv/
tests/
72 lines
sys/
contrib/
libnv/
23 lines

Diff 97789

View Options

lib/libnv/tests/nvlist_send_recv_test.c

Loading...
View Options

sys/contrib/libnv/nvlist.c

Loading...