PR: 258617 258618 258619 258620
Approved by: maintainer, meta (mentor), ygy (mentor)
Details
Details
- Reviewers
meta ygy - Commits
- R11:58471a55f7f2: */*: Update maintainer email
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 41824 Build 38712: arc lint + arc unit
Event Timeline
Comment Actions
Not bad but I would write commit message like this:
*/*: Update maintainer email - devel/lua-stdlib-debug - devel/lua-stdlib-normalize - mail/smfsav - mail/smfsav-devel PR: Submitted by: Approved by:
Also, don't forget to include 'Submitted by:' line. It can be written in short by username like Submitted by: meta if the submitter is a FreeBSD developer.
If the submitter is maintainer, append '(maintainer)' on the line end.
Comment Actions
Almost fine but don't forget to add 'Submitted by:' line. Go ahead after adding the line.
Comment Actions
As discussed, the "Submitted by" field is deprecated - please use author field.
We should also request the reporter to change their address in Bugzilla to this new address.
Comment Actions
Changes are LGTM. However, I think push will be rejected author of the commit is different from committer.
Comment Actions
Hmm, it appears to be OK. Sorry for the noise.
https://cgit.freebsd.org/ports/commit/?id=1ba20a0d92e2b1f5f9fd267ee50a31dac540f126
https://cgit.freebsd.org/ports/commit/?id=97ee34980fa2a4e8aaf03b19d5bda930e602641b
Comment Actions
I was suggested to use git push --push-option=confirm-author when I executed git push first.
Just FYI.
Comment Actions
This is standard procedure. Sometimes committers could make mistakes in the author field, usually their personal mail or Charlie Root. The push option gives an opportunity to double-check before the commit is final.