Page MenuHomeFreeBSD

cam: Avoiding waking up doneq threads if we're dumping
ClosedPublic

Authored by markj on Sep 24 2021, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 23, 8:55 PM
Unknown Object (File)
Sun, Mar 22, 5:33 PM
Unknown Object (File)
Fri, Mar 13, 12:18 PM
Unknown Object (File)
Feb 26 2026, 8:14 PM
Unknown Object (File)
Jan 31 2026, 1:36 AM
Unknown Object (File)
Jan 29 2026, 2:13 AM
Unknown Object (File)
Jan 28 2026, 6:03 PM
Unknown Object (File)
Jan 27 2026, 8:21 PM
Subscribers

Details

Summary

Depending on the state of the doneq thread at the time of the panic, the
wakeup can hang indefinitely in thread_lock_block_wait(). I think that
function should be modified to return immediately if the scheduler is
stopped, but it also seems more robust to avoid wakeups in general after
a panic.

Reported by: pho

Test Plan

Peter reported occasional hangs while dumping core after a panic,
resolved by this patch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable