Page MenuHomeFreeBSD

cam: Avoiding waking up doneq threads if we're dumping
ClosedPublic

Authored by markj on Sep 24 2021, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 31, 11:40 AM
Unknown Object (File)
Dec 26 2023, 10:16 PM
Unknown Object (File)
Dec 20 2023, 6:53 AM
Unknown Object (File)
Dec 14 2023, 8:41 PM
Unknown Object (File)
Oct 11 2023, 2:34 AM
Unknown Object (File)
Sep 21 2023, 11:32 AM
Unknown Object (File)
Aug 16 2023, 9:42 AM
Unknown Object (File)
Aug 8 2023, 3:47 AM
Subscribers

Details

Summary

Depending on the state of the doneq thread at the time of the panic, the
wakeup can hang indefinitely in thread_lock_block_wait(). I think that
function should be modified to return immediately if the scheduler is
stopped, but it also seems more robust to avoid wakeups in general after
a panic.

Reported by: pho

Test Plan

Peter reported occasional hangs while dumping core after a panic,
resolved by this patch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable