Page MenuHomeFreeBSD

cam: Avoiding waking up doneq threads if we're dumping
ClosedPublic

Authored by markj on Sep 24 2021, 7:40 PM.
Tags
None
Referenced Files
F143231888: D32126.id.diff
Tue, Jan 27, 8:21 PM
F143222699: D32126.diff
Tue, Jan 27, 4:57 PM
Unknown Object (File)
Tue, Jan 20, 2:37 PM
Unknown Object (File)
Dec 27 2025, 9:28 PM
Unknown Object (File)
Nov 28 2025, 11:24 AM
Unknown Object (File)
Nov 16 2025, 11:31 PM
Unknown Object (File)
Nov 16 2025, 11:31 PM
Unknown Object (File)
Nov 16 2025, 11:31 PM
Subscribers

Details

Summary

Depending on the state of the doneq thread at the time of the panic, the
wakeup can hang indefinitely in thread_lock_block_wait(). I think that
function should be modified to return immediately if the scheduler is
stopped, but it also seems more robust to avoid wakeups in general after
a panic.

Reported by: pho

Test Plan

Peter reported occasional hangs while dumping core after a panic,
resolved by this patch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41729
Build 38618: arc lint + arc unit