Page MenuHomeFreeBSD

cam: Avoiding waking up doneq threads if we're dumping
ClosedPublic

Authored by markj on Sep 24 2021, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 5, 3:22 PM
Unknown Object (File)
Sat, May 31, 6:31 AM
Unknown Object (File)
Sat, May 31, 4:38 AM
Unknown Object (File)
Apr 12 2025, 1:17 PM
Unknown Object (File)
Apr 12 2025, 12:53 AM
Unknown Object (File)
Mar 31 2025, 3:03 PM
Unknown Object (File)
Mar 12 2025, 11:15 PM
Unknown Object (File)
Mar 6 2025, 3:32 PM
Subscribers

Details

Summary

Depending on the state of the doneq thread at the time of the panic, the
wakeup can hang indefinitely in thread_lock_block_wait(). I think that
function should be modified to return immediately if the scheduler is
stopped, but it also seems more robust to avoid wakeups in general after
a panic.

Reported by: pho

Test Plan

Peter reported occasional hangs while dumping core after a panic,
resolved by this patch.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41729
Build 38618: arc lint + arc unit