Differential D31996

riscv: Add a stub pmap_change_attr implementation
ClosedPublic
Actions

Authored by jrtc27 on Sep 16 2021, 11:31 PM.

Details

Reviewers

markj
mhorne

Group Reviewers

riscv

Commits

rG2649bef7e4ab: riscv: Add a stub pmap_change_attr implementation
rG1be2e16df1d2: riscv: Add a stub pmap_change_attr implementation

Summary

pmap_change_attr is required by drm-kmod so we need the function to
exist. Since the Svpbmt extension is on the horizon we will likely end
up with a real implementation of it, so this stub implementation does
all the necessary page table walking to validate the input, ensuring
that no new errors are returned once it's implemented fully (other than
due to out of memory conditions when demoting L2 entries) and providing
a skeleton for that future implementation.

MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41556
Build 38445: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Sep 16 2021, 11:31 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 16 2021, 11:31 PM

jrtc27 requested review of this revision.Sep 16 2021, 11:31 PM

Harbormaster completed remote builds in B41556: Diff 95270.Sep 16 2021, 11:31 PM

jrtc27 edited the summary of this revision. (Show Details)Sep 16 2021, 11:52 PM

Handle L1 pages as those are uesd for the direct map

QEMU's devices are seemingly all too simple to ever hit the direct map case, but
on real hardware if_cgem quickly trips up on this and panics during attach in
pmap_page_set_memattr.

Harbormaster completed remote builds in B41560: Diff 95277.Sep 17 2021, 2:51 AM

markj accepted this revision.Sep 17 2021, 2:31 PM

This revision is now accepted and ready to land.Sep 17 2021, 2:31 PM

Closed by commit rG1be2e16df1d2: riscv: Add a stub pmap_change_attr implementation (authored by jrtc27). · Explain WhyOct 3 2021, 6:37 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG1be2e16df1d2: riscv: Add a stub pmap_change_attr implementation.

jrtc27 added a commit: rG2649bef7e4ab: riscv: Add a stub pmap_change_attr implementation.Oct 10 2021, 1:38 PM