Differential D31964

endian.h: Use the __bswap* versions
ClosedPublic
Actions

Authored by imp on Sep 14 2021, 10:23 PM.

Details

Reviewers

emaste
jhb
markj

Commits

rG6f3e6234f8be: endian.h: Use the __bswap* versions
rG44fb3c695f5e: endian.h: Use the __bswap* versions

Summary

Make it possible to have all these macros work without bswap* being
defined. bswap* is part of the application namespace and applications
are free to redefine those functions.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41518
Build 38407: arc lint + arc unit

Event Timeline

imp requested review of this revision.Sep 14 2021, 10:23 PM

imp created this revision.

Harbormaster completed remote builds in B41518: Diff 95183.Sep 14 2021, 10:23 PM

imp edited the test plan for this revision. (Show Details)Sep 14 2021, 10:24 PM

imp added reviewers: emaste, jhb, markj.

imp added a child revision: D31962: linux: For better compatibility, provide compatible endian.h.

markj accepted this revision.Sep 15 2021, 1:23 PM

This revision is now accepted and ready to land.Sep 15 2021, 1:23 PM

emaste accepted this revision.Sep 15 2021, 1:40 PM

jhb accepted this revision.Sep 15 2021, 5:25 PM

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258544 just to be sure...

imp mentioned this in D19500: Add endian.h to LHDRS..Sep 16 2021, 7:57 PM

After the exp run, this likely is fine to go in. No failures from this change were detected.

Closed by commit rG44fb3c695f5e: endian.h: Use the __bswap* versions (authored by imp). · Explain WhySep 21 2021, 4:10 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG44fb3c695f5e: endian.h: Use the __bswap* versions.

imp added a commit: rG6f3e6234f8be: endian.h: Use the __bswap* versions.Jan 24 2023, 11:28 PM

Revision Contents
Changeset List

Path

Size

sys/

endian.h

24 lines

Diff 95183

View Options

endian.h: Use the __bswap* versionsClosedPublicActions