Page MenuHomeFreeBSD
Differential D31939

efitable: Don't pass NULL as a format string to xo_err().
ClosedPublic
Actions

Authored by jhb on Sep 13 2021, 6:21 PM.
Tags
None
Referenced Files
F156748077: D31939.id95207.diff
Sat, May 16, 2:21 AM
F156748067: D31939.id95065.diff
Sat, May 16, 2:21 AM
F156748025: D31939.diff
Sat, May 16, 2:21 AM
Unknown Object (File)
Tue, May 12, 4:00 PM
Unknown Object (File)
Tue, May 5, 11:24 PM
Unknown Object (File)
Thu, Apr 30, 6:08 PM
Unknown Object (File)
Wed, Apr 29, 1:02 AM
Unknown Object (File)
Wed, Apr 29, 1:00 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
emaste
Commits
rGb14cd3a8339e: efitable: Don't pass NULL as a format string to xo_err().
Summary

This fixes a -Wformat error reported by GCC 9.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41493
Build 38382: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 13 2021, 6:21 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 13 2021, 6:21 PM
jhb requested review of this revision.Sep 13 2021, 6:21 PM
Harbormaster completed remote builds in B41493: Diff 95065.Sep 13 2021, 6:21 PM
kib accepted this revision.Sep 13 2021, 6:54 PM
kib added inline comments.
usr.sbin/efitable/efitable.c
149

I suggest to add something like '(len == 0)' into the string, to distinguish two calls.

This revision is now accepted and ready to land.Sep 13 2021, 6:54 PM
jhb marked an inline comment as done.Sep 15 2021, 3:40 PM
Closed by commit rGb14cd3a8339e: efitable: Don't pass NULL as a format string to xo_err(). (authored by jhb). · Explain WhySep 15 2021, 4:06 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGb14cd3a8339e: efitable: Don't pass NULL as a format string to xo_err()..

Revision Contents
Changeset List

PathSize
usr.sbin/
efitable/
4 lines

Diff 95065

View Options

usr.sbin/efitable/efitable.c

Loading...