Differential D31892

iscsi: Abort data-out tasks queued on a terminating session.
ClosedPublic
Actions

Authored by jhb on Sep 9 2021, 6:27 PM.

Tags

None

Referenced Files

	F144432116: D31892.id95233.diff
	Sun, Feb 8, 10:12 AM

	F144323401: D31892.id94929.diff
	Sat, Feb 7, 8:33 PM

	Unknown Object (File)
	Sat, Jan 31, 3:19 PM

	Unknown Object (File)
	Dec 12 2025, 9:01 AM

	Unknown Object (File)
	Nov 28 2025, 8:11 PM

	Unknown Object (File)
	Nov 28 2025, 3:00 AM

	Unknown Object (File)
	Nov 20 2025, 9:55 AM

	Unknown Object (File)
	Nov 12 2025, 2:28 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGb2f1beeeff10: iscsi: Abort data-out tasks queued on a terminating session.
rG0cd6e85e242b: iscsi: Abort data-out tasks queued on a terminating session.

Summary

cfiscsi_datamove_out() can race with cfiscsi_session_terminate_tasks()
and enqueue a new task after the latter function has aborted existing
tasks. This could result in a deadlock as
cfiscsi_session_terminate_tasks() waited forever for this task to
complete.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41450
Build 38339: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 9 2021, 6:27 PM

Herald added a reviewer: cam. · View Herald TranscriptSep 9 2021, 6:27 PM

Herald added a subscriber: imp. · View Herald Transcript

jhb requested review of this revision.Sep 9 2021, 6:27 PM

Harbormaster completed remote builds in B41450: Diff 94929.Sep 9 2021, 6:27 PM

jhb added a parent revision: D31891: iscsi: Add a helper routine to abort a data-out task..Sep 9 2021, 6:27 PM

mav accepted this revision.Sep 12 2021, 12:59 AM

This revision is now accepted and ready to land.Sep 12 2021, 12:59 AM

Closed by commit rG0cd6e85e242b: iscsi: Abort data-out tasks queued on a terminating session. (authored by jhb). · Explain WhySep 15 2021, 8:30 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0cd6e85e242b: iscsi: Abort data-out tasks queued on a terminating session..

jhb added a commit: rGb2f1beeeff10: iscsi: Abort data-out tasks queued on a terminating session..Oct 30 2021, 12:02 AM

Revision Contents
Changeset List

Path

Size

sys/

cam/

ctl/

ctl_frontend_iscsi.c

5 lines

Diff 94929

sys/cam/ctl/ctl_frontend_iscsi.c

Loading...