NetBSD split newfs_msdos in two so that they can reuse the file system creation part in makefs. I want to do the same thing with our makefs. This revision is a mechanical change that refactors the option handling as NetBSD has done so that it can be reviewed in isolation, and so that subsequent functional changes can be reviewed without extra noise.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| sbin/newfs_msdos/newfs_msdos.c | ||
|---|---|---|
| 104–117 | NetBSD renamed these as struct bsbpb {
u_int8_t bps[2]; /* bytes per sector */
u_int8_t spc; /* sectors per cluster */
u_int8_t res[2]; /* reserved sectors */
u_int8_t nft; /* number of FATs */
u_int8_t rde[2]; /* root directory entries */
u_int8_t sec[2]; /* total sectors */
u_int8_t mid; /* media descriptor */
u_int8_t spf[2]; /* sectors per FAT */
u_int8_t spt[2]; /* sectors per track */
u_int8_t hds[2]; /* drive heads */
u_int8_t hid[4]; /* hidden sectors */
u_int8_t bsec[4]; /* big total sectors */
};and similar for the other structs. I plan to apply the same change to our tree to continue reducing diffs. | |
Comment Actions
The change looks good. I don't know if we want further changes though.
| sbin/newfs_msdos/newfs_msdos.c | ||
|---|---|---|
| 104–117 | Hmm ... actually they didn't change: we did. There was an effort to unify the headers as we carry three different headers for FAT in:
There are also yet another version (EFI I think). We never finished unifying them but at least we were using similar names. | |