crunchide: address complaints from WARNS=6
ClosedPublic
Actions

Authored by kevans on Aug 19 2021, 6:44 AM.

Tags

None

Referenced Files

	F161827486: D31608.diff
	Tue, Jul 7, 4:35 AM

	Unknown Object (File)
	Mon, Jun 22, 10:21 PM

	Unknown Object (File)
	Wed, Jun 17, 8:31 PM

	Unknown Object (File)
	Wed, Jun 17, 12:53 PM

	Unknown Object (File)
	Tue, Jun 16, 5:44 PM

	Unknown Object (File)
	May 4 2026, 1:13 AM

	Unknown Object (File)
	May 2 2026, 8:44 AM

	Unknown Object (File)
	Apr 28 2026, 7:15 PM

View All Files

Subscribers

imp

Details

Reviewers

arichardson
emaste
imp

Commits

rGdd7c7ff192d0: crunchide: address complaints from WARNS=6

Summary

One (1) constify
One (1) argument is unused
One (1) local shadows a global
Various globals that should be static

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41131
Build 38020: arc lint + arc unit

Event Timeline

kevans created this revision.Aug 19 2021, 6:44 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 19 2021, 6:44 AM

Harbormaster completed remote builds in B41131: Diff 93918.Aug 19 2021, 6:44 AM

kevans requested review of this revision.Aug 19 2021, 6:44 AM

arichardson accepted this revision.Aug 19 2021, 7:51 AM

This revision is now accepted and ready to land.Aug 19 2021, 7:51 AM

imp accepted this revision.Aug 19 2021, 1:16 PM

Closed by commit rGdd7c7ff192d0: crunchide: address complaints from WARNS=6 (authored by kevans). · Explain WhyAug 19 2021, 5:49 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGdd7c7ff192d0: crunchide: address complaints from WARNS=6.

Revision Contents
Changeset List

Path

Size

usr.sbin/

crunch/

crunchide/

crunchide.c

8 lines

exec_elf32.c

10 lines

Diff 93918

View Options

usr.sbin/crunch/crunchide/crunchide.c