crunchide: address complaints from WARNS=6
ClosedPublic
Actions

Authored by kevans on Aug 19 2021, 6:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 22, 8:26 AM

	Unknown Object (File)
	Tue, Apr 21, 2:01 AM

	Unknown Object (File)
	Mon, Apr 20, 10:16 AM

	Unknown Object (File)
	Sun, Apr 19, 3:10 PM

	Unknown Object (File)
	Sat, Apr 18, 11:11 PM

	Unknown Object (File)
	Sat, Apr 11, 4:45 PM

	Unknown Object (File)
	Mon, Apr 6, 4:01 PM

	Unknown Object (File)
	Mon, Apr 6, 7:17 AM

View All Files

Subscribers

imp

Details

Reviewers

arichardson
emaste
imp

Commits

rGdd7c7ff192d0: crunchide: address complaints from WARNS=6

Summary

One (1) constify
One (1) argument is unused
One (1) local shadows a global
Various globals that should be static

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41131
Build 38020: arc lint + arc unit

Event Timeline

kevans created this revision.Aug 19 2021, 6:44 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 19 2021, 6:44 AM

Harbormaster completed remote builds in B41131: Diff 93918.Aug 19 2021, 6:44 AM

kevans requested review of this revision.Aug 19 2021, 6:44 AM

arichardson accepted this revision.Aug 19 2021, 7:51 AM

This revision is now accepted and ready to land.Aug 19 2021, 7:51 AM

imp accepted this revision.Aug 19 2021, 1:16 PM

Closed by commit rGdd7c7ff192d0: crunchide: address complaints from WARNS=6 (authored by kevans). · Explain WhyAug 19 2021, 5:49 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGdd7c7ff192d0: crunchide: address complaints from WARNS=6.

Revision Contents
Changeset List

Path

Size

usr.sbin/

crunch/

crunchide/

crunchide.c

8 lines

exec_elf32.c

10 lines

Diff 93918

View Options

usr.sbin/crunch/crunchide/crunchide.c