OpenSSL: Only enable KTLS if it is explicitly configured
ClosedPublic
Actions

Authored by jhb on Aug 6 2021, 11:37 PM.

Details

Reviewers

Commits

rG622809b0868f: OpenSSL: Only enable KTLS if it is explicitly configured
rG62ca9fc1ad56: OpenSSL: Only enable KTLS if it is explicitly configured

Summary

It has always been the case that KTLS is not compiled by default. However
if it is compiled then it was automatically used unless specifically
configured not to. This is problematic because it avoids any crypto
implementations from providers. A user who configures all crypto to use
the FIPS provider may unexpectedly find that TLS related crypto is actually
being performed outside of the FIPS boundary.

Instead we change KTLS so that it is disabled by default.

We also swap to using a single "option" (i.e. SSL_OP_ENABLE_KTLS) rather
than two separate "modes", (i.e. SSL_MODE_NO_KTLS_RX and
SSL_MODE_NO_KTLS_TX).

Obtained from: OpenSSL (a3a54179b6754fbed6d88e434baac710a83aaf80)
Sponsored by: Netflix
MFC after: 1 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Aug 6 2021, 11:37 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 6 2021, 11:37 PM

jhb requested review of this revision.Aug 6 2021, 11:37 PM

jhb added a parent revision: D31439: OpenSSL: ktls: Initial support for ChaCha20-Poly1305.

jhb added a child revision: D31441: OpenSSL: Update KTLS documentation.

Harbormaster completed remote builds in B40906: Diff 93352.Aug 6 2021, 11:37 PM

jhb added a parent revision: D31445: nfs tls: Update for SSL_OP_ENABLE_KTLS..Aug 6 2021, 11:39 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 17 2021, 9:46 PM

Closed by commit rG62ca9fc1ad56: OpenSSL: Only enable KTLS if it is explicitly configured (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG62ca9fc1ad56: OpenSSL: Only enable KTLS if it is explicitly configured.

jhb added a commit: rG622809b0868f: OpenSSL: Only enable KTLS if it is explicitly configured.Aug 24 2021, 1:02 AM

Will the MFC to stable/13 of this change unbreak not working kTLS in this branch? It looks like after recent OpenSSL upgrade kTLS stoped working here. Now stable/13 in the base system has OpenSSL 1.1.1l-freebsd 24 Aug 2021 is installed and despite the fact it was built with WITH_OPENSSL_KTLS=yes and enabled ,all kTLS related stats are empty:
kern.ipc.tls.stats.ocf.tls13_gcm_crypts: 0
kern.ipc.tls.stats.ocf.tls12_gcm_crypts: 0
kern.ipc.tls.stats.ocf.tls11_cbc_crypts: 0
kern.ipc.tls.stats.ocf.tls10_cbc_crypts: 0

This change was already MFC'd to stable/13. Note that because of this change, you now need to enable KTLS explicitly as an SSL option. One way is to use a config file (and in a followup to the commit to main I gave an example config file which does this).

In D31440#723967, @jhb wrote:

This change was already MFC'd to stable/13. Note that because of this change, you now need to enable KTLS explicitly as an SSL option. One way is to use a config file (and in a followup to the commit to main I gave an example config file which does this).

Thank you for the answer. So OpenSSL 1.1.1l-freebsd 24 Aug 2021 which is now in the base system of stable/13, which was built with WITH_OPENSSL_KTLS=yes and enabled by settings these sysctls:
kern.ipc.mb_use_ext_pgs=1
kern.ipc.tls.ifnet.permitted=1
kern.ipc.tls.enable=1

with these settings in /etc/ssl/openssl.cnf

openssl_conf = openssl_init
[ openssl_init ]
ssl_conf = ssl_sect
[ ssl_sect ]
system_default = system_default_sect
[ system_default_sect ]
Options = KTLS

should work as before? Am I missing anything? I am still not able to make it working as it used to before late upgrades performed by late summer.

I am sorry for the noise. Everything works fine. It looks like /etc/ssl/openssl.cnf was a bit overweight and busted.

No worries, glad it is working for you. I will likely default WITH_OPENSSL_KTLS to on in stable/13 in the near future so that 13.1 includes KTLS support in OpenSSL by default.