Page MenuHomeFreeBSD
Differential D31481

linux(4): Implement CLONE_CLEAR_SIGHAND option bit.
ClosedPublic
Actions

Authored by dchagin on Aug 9 2021, 7:53 PM.
Tags
None
Referenced Files
F167793542: D31481.id93462.diff
Mon, Aug 24, 2:26 PM
F167761151: D31481.id93606.diff
Mon, Aug 24, 8:47 AM
F167729731: D31481.id93477.diff
Mon, Aug 24, 2:26 AM
F167706745: D31481.id93477.diff
Sun, Aug 23, 9:34 PM
F167706032: D31481.id93462.diff
Sun, Aug 23, 9:30 PM
F167699172: D31481.id93476.diff
Sun, Aug 23, 8:42 PM
F167696332: D31481.id93606.diff
Sun, Aug 23, 8:18 PM
F167677321: D31481.id93462.diff
Sun, Aug 23, 5:31 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
Group Reviewers
Linux Emulation
Commits
rG3af6bc9d02cd: linux(4): Implement CLONE_CLEAR_SIGHAND option bit.
rGc5fc9fe7f36a: linux(4): Implement CLONE_CLEAR_SIGHAND option bit.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40958
Build 37847: arc lint + arc unit

Event Timeline

dchagin created this revision.Aug 9 2021, 7:53 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 9 2021, 7:53 PM
dchagin requested review of this revision.Aug 9 2021, 7:53 PM
Harbormaster completed remote builds in B40951: Diff 93462.Aug 9 2021, 7:53 PM
dchagin added reviewers: kib, Linux Emulation.Aug 9 2021, 9:53 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
kib added a comment.Aug 10 2021, 12:28 AM

Can you explain the semantic of CLEAR_SIGHAND, or provide a reference to the official doc?

sys/compat/linux/linux_fork.c
142

This leaves f2 uninitialize if CLEAR_SIGHAND is not specified, no?

dchagin updated this revision to Diff 93476.Aug 10 2021, 8:36 AM

fixed, CLONE_CLEAR_SIGHAND is designed to reset all signal handlers of the child
not set to SIG_IGN to SIG_DFL.

Harbormaster completed remote builds in B40958: Diff 93476.Aug 10 2021, 8:36 AM
kib added inline comments.Aug 10 2021, 9:18 AM
sys/compat/linux/linux_fork.c
155

Please do '|=' instead of '='.

dchagin updated this revision to Diff 93477.Aug 10 2021, 9:23 AM

fixed

Harbormaster completed remote builds in B40959: Diff 93477.Aug 10 2021, 9:23 AM
kib accepted this revision.Aug 10 2021, 9:44 AM
kib added inline comments.
sys/compat/linux/linux_fork.c
142

I would also moved the initialization of ff there, from the declaration block.

This revision is now accepted and ready to land.Aug 10 2021, 9:44 AM
Closed by commit rGc5fc9fe7f36a: linux(4): Implement CLONE_CLEAR_SIGHAND option bit. (authored by dchagin). · Explain WhyAug 12 2021, 8:57 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGc5fc9fe7f36a: linux(4): Implement CLONE_CLEAR_SIGHAND option bit..
dchagin added a commit: rG3af6bc9d02cd: linux(4): Implement CLONE_CLEAR_SIGHAND option bit..Jun 17 2022, 7:39 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
2 lines

Diff 93476

View Options

sys/compat/linux/linux_fork.c

Loading...